sandbox/linux/services/credentials.h - Issue 915823002: Namespace sandbox: add important security checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/services/credentials.h

Issue 915823002: Namespace sandbox: add important security checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better documentation. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/services/credentials.h

diff --git a/sandbox/linux/services/credentials.h b/sandbox/linux/services/credentials.h

index a52617690bd0d877299a745f4bfc15195f9ca3f7..5121602a9f46534262c0fa6415bdbe8f68e885b5 100644

--- a/sandbox/linux/services/credentials.h

+++ b/sandbox/linux/services/credentials.h

@@ -26,7 +26,8 @@ namespace sandbox {

class SANDBOX_EXPORT Credentials {

public:

// Drop all capabilities in the effective, inheritable and permitted sets for

- // the current process.

+ // the current process. For security reasons, the caller is responsible

+ // for ensuring it is single threaded when calling this API.

rickyz (no longer on Chrome) 2015/02/11 22:59:56 It might be good to explicitly mention the reason

jln (very slow on Chromium) 2015/02/11 23:13:07 Done.

static bool DropAllCapabilities() WARN_UNUSED_RESULT;

// Return true iff there is any capability in any of the capabilities sets

// of the current process.