Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 9158014: Disallow assignment to a top level method in dartc (Closed)

Created:
8 years, 11 months ago by zundel
Modified:
8 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +7 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/language/language-leg.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/src/AssignInstanceMethodNegativeTest.dart View 1 chunk +3 lines, -10 lines 0 comments Download
A tests/language/src/AssignTopMethodNegativeTest.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 11 months ago (2012-01-10 16:29:08 UTC) #1
scheglov
8 years, 11 months ago (2012-01-10 16:34:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698