Issue 9158003: Added Me2Me-specific authenticator factory.

Issue 9158003: Added Me2Me-specific authenticator factory. (Closed)

Created:
8 years, 11 months ago by Sergey Ulanov

Modified:
8 years, 11 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added Me2Me-specific authenticator factory. BUG=105214 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116968

Patch Set 1 #

Total comments: 4

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : fix clang build #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -18 lines)			Patch
M	remoting/host/remoting_me2me_host.cc	View		2 chunks	+8 lines, -7 lines	0 comments	Download
M	remoting/host/simple_host_process.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
A	remoting/protocol/me2me_host_authenticator_factory.h	View		1 chunk	+48 lines, -0 lines	0 comments	Download
A	remoting/protocol/me2me_host_authenticator_factory.cc	View	1 2 3	1 chunk	+63 lines, -0 lines	0 comments	Download
M	remoting/protocol/v2_authenticator.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	remoting/remoting.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

lgtm http://codereview.chromium.org/9158003/diff/1/remoting/protocol/me2me_host_authenticator_factory.cc File remoting/protocol/me2me_host_authenticator_factory.cc (right): http://codereview.chromium.org/9158003/diff/1/remoting/protocol/me2me_host_authenticator_factory.cc#newcode48 remoting/protocol/me2me_host_authenticator_factory.cc:48: if (V2Authenticator::IsEkeMessage(first_message)) { Comment this out since V2 ...

8 years, 11 months ago (2012-01-09 23:04:46 UTC) #2

Sergey Ulanov

8 years, 11 months ago (2012-01-09 23:08:13 UTC) #3

http://codereview.chromium.org/9158003/diff/1/remoting/protocol/me2me_host_au...
File remoting/protocol/me2me_host_authenticator_factory.cc (right):

http://codereview.chromium.org/9158003/diff/1/remoting/protocol/me2me_host_au...
remoting/protocol/me2me_host_authenticator_factory.cc:48: if
(V2Authenticator::IsEkeMessage(first_message)) {
On 2012/01/09 23:04:47, Wez wrote:
> Comment this out since V2 is not ready yet?

Done.

http://codereview.chromium.org/9158003/diff/1/remoting/protocol/me2me_host_au...
File remoting/protocol/me2me_host_authenticator_factory.h (right):

http://codereview.chromium.org/9158003/diff/1/remoting/protocol/me2me_host_au...
remoting/protocol/me2me_host_authenticator_factory.h:27: const
crypto::RSAPrivateKey* local_private_key,
On 2012/01/09 23:04:47, Wez wrote:
> Any reason not to use |const crypto::RSAPrivateKey&| here?

For consistency with other code. I'll make separate CL to change it to ref
everywhere.

Expand Messages | Collapse Messages