tools/perf/measurements/page_cycler.py - Issue 91573003: Make page_cycler.py fully measure memory for each page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 91573003: Make page_cycler.py fully measure memory for each page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Tony and Quinten's comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index a0fdc470b7d0bc5c3633201e8c27e223142ded2e..32ffe6dab52c8175521dddc7607b144dbf8eb526 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -176,7 +176,6 @@ class PageCycler(page_measurement.PageMeasurement):

tab, results, chart_name=chart_name_prefix+'speed_index')

def DidRunTest(self, browser, results):

- self._memory_metric.AddSummaryResults(results)

io.IOMetric().AddSummaryResults(browser, results)

def IsRunCold(self, url):