tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py - Issue 91573003: Make page_cycler.py fully measure memory for each page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

Issue 91573003: Make page_cycler.py fully measure memory for each page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Shadi's comment Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py b/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

index 5505a0f60616e5ebcefb0dfa243dc9329ffa896b..4a56a056ca6095e86191eafc6bcceaede4c71b94 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

@@ -34,6 +34,5 @@ def GetIfChanged(profiler_binary):

def InstallOnDevice(adb, profiler_binary):

GetIfChanged(profiler_binary)

- adb.Adb().PushIfNeeded(GetHostPath(profiler_binary),

- GetDevicePath(profiler_binary))

- adb.Adb().RunShellCommand('chmod 777 ' + GetDevicePath(profiler_binary))

+ adb.PushIfNeeded(GetHostPath(profiler_binary), GetDevicePath(profiler_binary))

+ adb.RunShellCommand('chmod 777 ' + GetDevicePath(profiler_binary))