Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 915703002: Add task location information to ExecutionContext (Closed)

Created:
5 years, 10 months ago by Sami
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, tzik, sof, eae+blinkwatch, tommyw+watchlist_chromium.org, nhiroki, Raymond Toy, falken, blink-reviews-dom_chromium.org, dglazkov+blink, kinuko+worker_chromium.org, horo+watch_chromium.org, kinuko+fileapi, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -64 lines) Patch
M Source/core/dom/Document.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StringCallback.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/NetworkStateNotifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/NullExecutionContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/NullExecutionContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystem.h View 7 chunks +7 lines, -6 lines 0 comments Download
M Source/modules/filesystem/LocalFileSystem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransactionClient.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Sami
PTAL. This patch looks big but it's very mechanical.
5 years, 10 months ago (2015-02-19 20:01:27 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-19 23:09:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915703002/20001
5 years, 10 months ago (2015-02-20 13:51:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190568
5 years, 10 months ago (2015-02-20 15:20:24 UTC) #6
Ken Russell (switch to Gerrit)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/941403002/ by kbr@chromium.org. ...
5 years, 10 months ago (2015-02-20 19:26:18 UTC) #7
Sami
Relanding -- turns out the memory regression was something else: https://code.google.com/p/chromium/issues/detail?id=460533
5 years, 10 months ago (2015-02-23 15:23:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915703002/20001
5 years, 10 months ago (2015-02-23 15:23:27 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 15:24:13 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190662

Powered by Google App Engine
This is Rietveld 408576698