Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 915693002: GYP groudwork for half-float opts support. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GYP groudwork for half-float opts support. This sets us up two new opts targets with the immediate goal of adding half-float (SkHalf.h) opts: - opts_neon_fp16: uses hardware support on most ARM chips with NEON to do 4 conversions at a time; - opts_avx: uses hardware support on Intel chips with AVX to do 8 conversions at a time. opts_avx will be a handy thing to have around later too, especially if we want to work with floats. This doesn't actually add any new source files to these libraries yet, so they're no-ops for now. I'll need to write a parallel change to Chrome's GN and GYPs before we can start adding sources. This also rolls GYP up to head, to get suppport for EnableEnhancedInstructionSet: '3' on Windows, which is how we turn on AVX there. There's no Mac-specific flag, so we use OTHER_CPLUSPLUSFLAGS. BUG=skia: TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/46b80833394d7919cadf2abf2b93802141dd21c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/opts.gyp View 4 chunks +44 lines, -1 line 0 comments Download
M gyp/opts.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtklein_C
5 years, 10 months ago (2015-02-10 17:07:08 UTC) #2
mtklein
Landing this TBR so I can get working on the Chromium-side changes after it rolls.
5 years, 10 months ago (2015-02-10 17:09:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915693002/1
5 years, 10 months ago (2015-02-10 17:10:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/46b80833394d7919cadf2abf2b93802141dd21c5
5 years, 10 months ago (2015-02-10 17:17:10 UTC) #7
reed1
lgtm
5 years, 10 months ago (2015-02-10 17:23:12 UTC) #8
mtklein
5 years, 10 months ago (2015-02-11 02:17:33 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/912223002/ by mtklein@google.com.

The reason for reverting is: Going to punt on 16-bit float support for now. 
Can't figure out ARM 64..

Powered by Google App Engine
This is Rietveld 408576698