Issue 915663002: Only define SK_CRASH_HANDLER in crash_handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 915663002: Only define SK_CRASH_HANDLER in crash_handler. (Closed)

Created:
5 years, 10 months ago by scroggo

Modified:
5 years, 10 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Only define SK_CRASH_HANDLER in crash_handler. The macro is only used in CrashHandler.* Removes SK_CRASH_HANDLER from Android's SkUserConfig, where it is not needed. Committed: https://skia.googlesource.com/skia/+/ac928f27ab632784d6b9572901201caa2908caa5

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	gyp/common_conditions.gypi	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	gyp/tools.gyp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915663002/1

5 years, 10 months ago (2015-02-10 16:01:59 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-10 16:13:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ac928f27ab632784d6b9572901201caa2908caa5