Issue 915633002: discard when coverage is <= 0 in XP dst copy

Issue 915633002: discard when coverage is <= 0 in XP dst copy (Closed)

Created:
5 years, 10 months ago by joshua.litt

Modified:
5 years, 10 months ago

Reviewers:
joshualitt, bsalomon, egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

discard when coverage is <= 0 in XP dst copy. Darken was 5-20% slower with this CL, though it might improve things a bit to only look at one component of the vector. BUG=skia: Committed: https://skia.googlesource.com/skia/+/043e0f60f4890d523845b487d8373e1363a01812

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/gpu/gl/GrGLXferProcessor.cpp	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 9 (4 generated)

bsalomon

On 2015/02/10 15:22:09, joshualitt wrote: Yikes. What device was that on? Do we know if ...

5 years, 10 months ago (2015-02-10 16:21:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915633002/60001

5 years, 10 months ago (2015-02-10 17:51:00 UTC) #8

commit-bot: I haz the power

5 years, 10 months ago (2015-02-10 18:06:18 UTC) #9

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/043e0f60f4890d523845b487d8373e1363a01812