Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 915583002: Massage the CodeStub class hierarchy a bit. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Massage the CodeStub class hierarchy a bit. Several tiny changes for the upcoming TurboFan-genrated handlers/stubs: * Relaxed the type of code_stub(). * Made GetCodeKind() public, it effectly was like this, anyway. * Const-corrected GetStubType(). Committed: https://crrev.com/6e4e43b652a43d54b2bf51777e781b8f91b251b6 Cr-Commit-Position: refs/heads/master@{#26542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M src/code-stubs.h View 11 chunks +13 lines, -15 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 10 months ago (2015-02-10 10:48:40 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-10 10:55:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915583002/1
5 years, 10 months ago (2015-02-10 11:24:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 11:46:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 11:46:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e4e43b652a43d54b2bf51777e781b8f91b251b6
Cr-Commit-Position: refs/heads/master@{#26542}

Powered by Google App Engine
This is Rietveld 408576698