super is only allowed in methods, accessors and constructor

super is only allowed in methods, accessors and constructor

super() is only allowed in a class constructor.
super.p is allowed in methods, accessors and constructors.

The parser now checks the FunctionState to see what kind of function
we are currently inside.

BUG=v8:3330
LOG=N
R=dslomov@chromium.org, marja@chromium.org

Committed: https://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02
Cr-Commit-Position: refs/heads/master@{#26557}

[arv (Not doing code reviews), 2015-02-10 16:51:30]

further test cleanup

[arv (Not doing code reviews), 2015-02-10 16:52:21]

PTAL

Most of the work here involved refactoring the tests since super is no longer
allowed in FunctionExpression/FunctionDeclaration.

[marja, 2015-02-10 17:10:56]

parsing lgtm

https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing...
test/cctest/test-parsing.cc:3692: {"class C { m() { () => ", "; } }"},
Maybe an interesting test case to add:

class C {
  m() {
    function foo() {
       << super usage here
    }
  }
}

That sound be an error, right?

https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing...
test/cctest/test-parsing.cc:3775: const char* succes_data[] = {
typo

[arv (Not doing code reviews), 2015-02-10 17:37:31]

New patchsets have been uploaded after l-g-t-m from marja@chromium.org

[arv (Not doing code reviews), 2015-02-10 17:37:32]

better test

[arv (Not doing code reviews), 2015-02-10 17:38:35]

Thanks for the review.

https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing...
test/cctest/test-parsing.cc:3692: {"class C { m() { () => ", "; } }"},
On 2015/02/10 17:10:56, marja wrote:
> Maybe an interesting test case to add:
> 
> class C {
>   m() {
>     function foo() {
>        << super usage here
>     }
>   }
> }
> 
> That sound be an error, right?

Yes. That should be an error. Adding a case to SuperErrorsNonMethods

https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing...
test/cctest/test-parsing.cc:3775: const char* succes_data[] = {
On 2015/02/10 17:10:56, marja wrote:
> typo

Done.

https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing...
test/cctest/test-parsing.cc:3792: const char* error_data[] = {
I screwed this up as well. I'll fix.

[arv (Not doing code reviews), 2015-02-10 17:57:23]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-02-10 17:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915563003/40001

[Dmitry Lomov (no reviews), 2015-02-10 18:13:38]

lgtm

[commit-bot: I haz the power, 2015-02-10 18:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 18:42:37]

Try jobs failed on following builders:
  v8_win_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/2955)

[arv (Not doing code reviews), 2015-02-10 18:58:41]

New patchsets have been uploaded after l-g-t-m from dslomov@chromium.org

[arv (Not doing code reviews), 2015-02-10 18:58:43]

git rebase

[arv (Not doing code reviews), 2015-02-10 18:58:51]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-02-10 18:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915563003/60001

[commit-bot: I haz the power, 2015-02-10 19:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 19:11:48]

Try jobs failed on following builders:
  v8_win_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/2959)

[arv (Not doing code reviews), 2015-02-10 19:28:15]

Use i:: to qualify function name

[arv (Not doing code reviews), 2015-02-10 19:28:25]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-02-10 19:29:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915563003/80001

[commit-bot: I haz the power, 2015-02-10 19:51:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-10 19:51:48]

Patchset 5 (id:??) landed as
https://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02
Cr-Commit-Position: refs/heads/master@{#26557}