Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 915563003: super is only allowed in methods, accessors and constructor (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

super is only allowed in methods, accessors and constructor super() is only allowed in a class constructor. super.p is allowed in methods, accessors and constructors. The parser now checks the FunctionState to see what kind of function we are currently inside. BUG=v8:3330 LOG=N R=dslomov@chromium.org, marja@chromium.org Committed: https://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02 Cr-Commit-Position: refs/heads/master@{#26557}

Patch Set 1 #

Patch Set 2 : further test cleanup #

Total comments: 5

Patch Set 3 : better test #

Patch Set 4 : git rebase #

Patch Set 5 : Use i:: to qualify function name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1428 lines, -1249 lines) Patch
M src/preparser.h View 1 2 3 4 6 chunks +40 lines, -18 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 5 chunks +268 lines, -74 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 chunk +0 lines, -6 lines 0 comments Download
M test/mjsunit/harmony/object-literals-super.js View 4 chunks +0 lines, -35 lines 0 comments Download
M test/mjsunit/harmony/super.js View 1 40 chunks +1119 lines, -1116 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
arv (Not doing code reviews)
further test cleanup
5 years, 10 months ago (2015-02-10 16:51:30 UTC) #1
arv (Not doing code reviews)
PTAL Most of the work here involved refactoring the tests since super is no longer ...
5 years, 10 months ago (2015-02-10 16:52:21 UTC) #2
marja
parsing lgtm https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing.cc#newcode3692 test/cctest/test-parsing.cc:3692: {"class C { m() { () => ...
5 years, 10 months ago (2015-02-10 17:10:56 UTC) #3
arv (Not doing code reviews)
better test
5 years, 10 months ago (2015-02-10 17:37:32 UTC) #5
arv (Not doing code reviews)
Thanks for the review. https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/915563003/diff/20001/test/cctest/test-parsing.cc#newcode3692 test/cctest/test-parsing.cc:3692: {"class C { m() { ...
5 years, 10 months ago (2015-02-10 17:38:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915563003/40001
5 years, 10 months ago (2015-02-10 17:58:33 UTC) #8
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-10 18:13:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/2955)
5 years, 10 months ago (2015-02-10 18:42:37 UTC) #11
arv (Not doing code reviews)
git rebase
5 years, 10 months ago (2015-02-10 18:58:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915563003/60001
5 years, 10 months ago (2015-02-10 18:59:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/2959)
5 years, 10 months ago (2015-02-10 19:11:48 UTC) #17
arv (Not doing code reviews)
Use i:: to qualify function name
5 years, 10 months ago (2015-02-10 19:28:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915563003/80001
5 years, 10 months ago (2015-02-10 19:29:23 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-10 19:51:26 UTC) #21
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:51:48 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9acfd4fe0825afb9284327327ed7edc185994e02
Cr-Commit-Position: refs/heads/master@{#26557}

Powered by Google App Engine
This is Rietveld 408576698