Chromium Code Reviews Chromium Code Reviews
Issue 915543003:
Schedule cursor update when DOM updates layout. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/events/mouse-cursor-change-after-layout.html |
| diff --git a/LayoutTests/fast/events/mouse-cursor-change.html b/LayoutTests/fast/events/mouse-cursor-change-after-layout.html |
| similarity index 70% |
| copy from LayoutTests/fast/events/mouse-cursor-change.html |
| copy to LayoutTests/fast/events/mouse-cursor-change-after-layout.html |
| index 224bb3f11f9c78fd8f6222db6f10d3f05c759350..92aabdff0533b4cc93842ffa68d6faaedfb604ea 100644 |
| --- a/LayoutTests/fast/events/mouse-cursor-change.html |
| +++ b/LayoutTests/fast/events/mouse-cursor-change-after-layout.html |
| @@ -2,21 +2,41 @@ |
| <html> |
| <head> |
| <script src="../../resources/js-test.js"></script> |
| +<script language="javascript" type="text/javascript"> |
| +function addOverlay() { |
| + var testContainer = document.getElementById('test-container'); |
| + var overlay = document.createElement('div'); |
| + overlay.id='overlay'; |
| + testContainer.appendChild(overlay); |
| +} |
| +</script> |
| <style type="text/css"> |
| +#target { |
| + cursor: default; |
| +} |
| +#overlay { |
| + cursor: wait; |
| + width: 200px; |
| + height: 200px; |
| + background: rgba(255,0,0,0.2); |
| + position: absolute; |
| + left: 0; |
| + top: 0; |
| +} |
| </style> |
| </head> |
| <body> |
| <p id="description"></p> |
| -<p><a href="https://bugs.webkit.org/show_bug.cgi?id=53341">Bug 53341</a></p> |
| +<p><a href="https://bugs.webkit.org/show_bug.cgi?id=26723">Bug 26723</a></p> |
|
Rick Byers
2015/02/20 20:54:00
nit: this a chrome bug, not webkit (which is from
zhengw
2015/02/20 21:05:10
Right, thanks for pointing out!
|
| <div id="test-container"> |
| - <div id="target" onMouseDown="style.cursor='progress';event.preventDefault();" onMouseMove="style.cursor='pointer';" onMouseUp="style.cursor='help';" style="cursor:pointer;">Play with mouse on this element. Cursors change on events - mousemove: pointer(hand), mousedown: progress, mouseup: help.</div> |
| + <div id="target" onMouseDown="addOverlay();event.preventDefault();">Click me</div> |
| </div> |
| <br/> |
| <div id="console"></div> |
| <script> |
| var CURSOR_UPDATE_DELAY = 50; |
| -description("Test that mouse cursors are changed correctly on mouse events."); |
| +description("Test that mouse cursors are changed correctly after layout."); |
| if (!window.eventSender) { |
| testFailed('This test requires DumpRenderTree'); |
| @@ -55,9 +75,6 @@ if (window.eventSender) { |
| debug('Mouse down'); |
| eventSender.mouseDown(); |
| }, function() { |
| - debug('Mouse hold down, move'); |
| - eventSender.mouseMoveTo(target.offsetLeft + 13, target.offsetTop + 3); |
| - }, function() { |
| debug('Mouse up'); |
| eventSender.mouseUp(); |
| } |
