Additional cleanups to Android config parsing.

tests/FontConfigParser.cpp

Index: tests/FontConfigParser.cpp
diff --git a/tests/FontConfigParser.cpp b/tests/FontConfigParser.cpp
index 744a41e5f2900c770ec4e6c1a620796beed53dbe..4e123d8824b7e9375cff13f2985b48f81f0c9539 100644
--- a/tests/FontConfigParser.cpp
+++ b/tests/FontConfigParser.cpp
@@ -37,9 +37,7 @@ void DumpLoadedFonts(SkTDArray<FontFamily*> fontFamilies) {
             case kCompact_FontVariant: SkDebugf("  compact\n"); break;
             default: break;
         }
-        if (fontFamilies[i]->fBasePath) {
-            SkDebugf("  basePath %s\n", fontFamilies[i]->fBasePath);
-        }
+        SkDebugf("  basePath %s\n", fontFamilies[i]->fBasePath.c_str());

[scroggo, 2015/02/10 13:59:41]

I'm guessing this bit-rotted due to SK_DEBUG_FONTS not being defined? Should we
define it for some builder?

[bungeman-skia, 2015/02/10 15:34:12]

I think it might be more due to the fact that I didn't add this change to my
previous CL. We should re-work this to avoid bit rot, for sure. I already have a
'--verboseFontMgr' flag which should work with this, with the benefit of
removing these 'ifdefs' and avoiding the dreaded random 'unreachable code'
warnings.

         if (!fontFamilies[i]->fLanguage.getTag().isEmpty()) {
             SkDebugf("  language %s\n", fontFamilies[i]->fLanguage.getTag().c_str());
         }