Fix alignment format in multiline mode

ui/gfx/render_text_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 
 #include "base/format_macros.h"
 #include "base/i18n/break_iterator.h"
@@ skipping 1985 matching lines @@
       continue;
 
     for (size_t j = 0; j < kTestStrings[i].lines_count; ++j) {
       SCOPED_TRACE(base::StringPrintf("Line %" PRIuS "", j));
       VerifyLineSegments(kTestStrings[i].line_char_ranges[j],
                          render_text.lines_[j].segments);
     }
   }
 }
 
+// Ensure RTL alignment works.
+TEST_F(RenderTextTest, Multiline_HorizontalAlignment) {
+  const struct {
+    const wchar_t* const text;
+    gfx::HorizontalAlignment alignment;
+  } kTestStrings[] = {
+    { L"abcdefghij\nhijkl", gfx::ALIGN_LEFT },
+    // hebrew
+    { L"\x5d0\x5d1\x5d2\x5d3\x5d4\x5d5\x5d6\x5d7\n\x5d0\x5d1\x5d2\x5d3",
+      gfx::ALIGN_RIGHT },
+    // arabic
+    { L"\x62a\x62b\x62c\x62d\x62e\x62f\x630\n\x660\x661\x662\x663\x664",
+      gfx::ALIGN_RIGHT },
+  };
+  RenderTextHarfBuzz render_text;
+  render_text.SetHorizontalAlignment(gfx::ALIGN_TO_HEAD);
+  render_text.set_glyph_width_for_test(5);
+  render_text.SetDisplayRect(Rect(100, 1000));
+  render_text.SetMultiline(true);
+
+  Canvas canvas;
+  for (size_t i = 0; i < arraysize(kTestStrings); ++i) {
+    SCOPED_TRACE(base::StringPrintf("kTestStrings[%" PRIuS "] %ls", i,
+                                    kTestStrings[i].text));
+    render_text.SetText(WideToUTF16(kTestStrings[i].text));
+    render_text.Draw(&canvas);
+    ASSERT_LE(2u, render_text.lines().size());
+    if (kTestStrings[i].alignment == gfx::ALIGN_LEFT) {
+      EXPECT_EQ(0, render_text.GetAlignmentOffset(0).x());
+      EXPECT_EQ(0, render_text.GetAlignmentOffset(1).x());
+    } else {
+      // Second string should be always shorter, thus

[msw, 2015/02/19 01:13:50]

nit: consider: "The second line in the test string is always shorter,"

+      // the seond line has longer alignment.

[msw, 2015/02/19 01:13:50]

nit: "second"

+      EXPECT_LT(render_text.GetAlignmentOffset(0).x(),
+                render_text.GetAlignmentOffset(1).x());
+    }
+  }
+}
+
 TEST_F(RenderTextTest, NewlineWithoutMultilineFlag) {
   const wchar_t* kTestStrings[] = {
     L"abc\ndef", L"a \n b ", L"ab\n", L"a\n\nb", L"\nab", L"\n",
   };
 
   RenderTextHarfBuzz render_text;
   render_text.SetDisplayRect(Rect(200, 1000));
   Canvas canvas;
 
   for (size_t i = 0; i < arraysize(kTestStrings); ++i) {
@@ skipping 367 matching lines @@
             base::StringToLowerASCII(fonts[0].GetActualFontNameForTesting()));
 
   scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
   render_text->SetDisplayRect(Rect(0, 0, 25, 25));
   render_text->SetFontList(font_list);
   EXPECT_GT(render_text->GetBaseline(), font_list.GetBaseline());
 }
 #endif
 
 }  // namespace gfx