Issue 915383002: Parser / PreParser: trivial unifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 915383002: Parser / PreParser: trivial unifications (Closed)

Created:
5 years, 10 months ago by marja

Modified:
5 years, 10 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Parser / PreParser: trivial unifications (To minimize the diff of actually interesting unifications.) R=rossberg@chromium.org BUG= Committed: https://crrev.com/30c71859edceae15d299534c0aecfb0362b94434 Cr-Commit-Position: refs/heads/master@{#26620}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -28 lines)			Patch
M	src/parser.h	View	1	2 chunks	+0 lines, -13 lines	0 comments	Download
M	src/preparser.h	View	1	3 chunks	+9 lines, -13 lines	0 comments	Download
M	src/preparser.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

marja

rossberg, ptal. just some trivial stuff split off actually interesting & bigger CLs (upcoming).

5 years, 10 months ago (2015-02-12 10:29:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915383002/40001

5 years, 10 months ago (2015-02-12 14:51:08 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-12 15:13:00 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/30c71859edceae15d299534c0aecfb0362b94434
Cr-Commit-Position: refs/heads/master@{#26620}