Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: sync/internal_api/attachments/attachment_service_proxy_unittest.cc

Issue 915373002: Migrate sync/ to base::RunLoop::RunUntilIdle() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/attachment_service_proxy_unittest.cc
diff --git a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
index d1b935637c78aed19ef03ab8eb17ca0ab69d27ce..2353d263c4b3522eaab02130f7096868b9c3c445 100644
--- a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
+++ b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
@@ -7,7 +7,6 @@
#include "base/bind.h"
#include "base/memory/ref_counted_memory.h"
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
@@ -172,7 +171,7 @@ TEST_F(AttachmentServiceProxyTest, MethodsAreProxied) {
// time to ensure the stub thread has executed the posted result callbacks.
WaitForStubThread();
- loop.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_EQ(1, count_callback_get_or_download);
EXPECT_EQ(1, count_callback_drop);
}
@@ -188,7 +187,7 @@ TEST_F(AttachmentServiceProxyTest, WrappedIsDestroyed) {
// callbacks.
WaitForStubThread();
- loop.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_EQ(1, count_callback_get_or_download);
// Destroy the stub and call GetOrDownloadAttachments again.
@@ -200,7 +199,7 @@ TEST_F(AttachmentServiceProxyTest, WrappedIsDestroyed) {
proxy->GetOrDownloadAttachments(AttachmentIdList(), callback_get_or_download);
WaitForStubThread();
WaitForStubThread();
- loop.RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_EQ(1, count_callback_get_or_download);
}
« no previous file with comments | « sync/engine/sync_scheduler_unittest.cc ('k') | sync/internal_api/attachments/attachment_store_test_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698