Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 915373002: Migrate sync/ to base::RunLoop::RunUntilIdle() (Closed)

Created:
5 years, 10 months ago by qi1988.yang
Modified:
5 years, 10 months ago
Reviewers:
stanisc
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate sync/ to base::RunLoop::RunUntilIdle() base::MessageLoop::RunUntilIdle() API is deprecated and the preferred way is using RunLoop now. BUG=333557 Committed: https://crrev.com/e7f7e82f95d39c2ee095c947e27e9f0c48e6f831 Cr-Commit-Position: refs/heads/master@{#318184}

Patch Set 1 #

Patch Set 2 : Fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M sync/engine/sync_scheduler_unittest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M sync/internal_api/attachments/attachment_store_test_template.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/fake_attachment_uploader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/js_mutation_event_observer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/js_sync_encryption_handler_observer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/js_sync_manager_observer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/util/weak_handle_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_encryption_handler_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/js/sync_js_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
qi1988.yang
PTAL! Thanks!
5 years, 10 months ago (2015-02-12 10:19:11 UTC) #2
stanisc
On 2015/02/12 10:19:11, qi1988.yang wrote: > PTAL! Thanks! There are build errors.
5 years, 10 months ago (2015-02-17 22:14:58 UTC) #3
qi1988.yang
Fixed build errors! PTAL,again! Thanks!
5 years, 10 months ago (2015-02-25 07:04:35 UTC) #4
stanisc
lgtm Looks good now.
5 years, 10 months ago (2015-02-25 18:54:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915373002/20001
5 years, 10 months ago (2015-02-26 02:03:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 04:25:03 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 04:25:31 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e7f7e82f95d39c2ee095c947e27e9f0c48e6f831
Cr-Commit-Position: refs/heads/master@{#318184}

Powered by Google App Engine
This is Rietveld 408576698