Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 915343002: Removing unused hasValidImageBuffer and activeSelectionStartListIndex (Closed)

Created:
5 years, 10 months ago by shiva.jm
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused hasValidImageBuffer and activeSelectionStartListIndex This patch removes the following unused functions: HTMLCanvasElement::hasValidImageBuffer() HTMLSelectElement::activeSelectionStartListIndex() BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M Source/core/html/HTMLCanvasElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shiva.jm
pls have a look.
5 years, 10 months ago (2015-02-12 09:06:16 UTC) #2
pdr.
LGTM Please wrap your change description at 72 characters. I recommend the following: Removing unused ...
5 years, 10 months ago (2015-02-12 21:58:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915343002/1
5 years, 10 months ago (2015-02-13 03:21:42 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 04:42:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190105

Powered by Google App Engine
This is Rietveld 408576698