[Mac] Remove -[NSWindow drawRect] swizzling.

[Mac] Remove -[NSWindow drawRect] swizzling.

This is no longer used.
Removed from FramedBrowserWindow here:
https://codereview.chromium.org/611453004
Removed from NativeAppWindowCocoa here:
https://codereview.chromium.org/916833005/

BUG=417872, 457991
Committed: https://crrev.com/dbf8bfd7fa34d69e880f0b8073a0441f439bf08a
Cr-Commit-Position: refs/heads/master@{#319395}

[jackhou1, 2015-02-25 05:17:25]

jackhou@chromium.org changed reviewers:
+ rsesek@chromium.org

[jackhou1, 2015-02-25 05:17:26]

rsesek, could you take a look?

[Robert Sesek, 2015-02-25 18:00:35]

I'm not sure this is no longer used. Also this does not compile.

[jackhou1, 2015-02-26 02:47:57]

On 2015/02/25 18:00:35, Robert Sesek wrote:
> I'm not sure this is no longer used. Also this does not compile.

Oops, sorry. Only removing the drawRect part this time. PTAL

[jackhou1, 2015-03-04 02:13:32]

rsesek, ping

[Robert Sesek, 2015-03-04 19:16:26]

Sorry, please ping sooner!

https://codereview.chromium.org/915313002/diff/60001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/custom_frame_view.mm (right):

https://codereview.chromium.org/915313002/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/custom_frame_view.mm:56: if
(base::mac::IsOSMavericksOrEarlier()) {
Since we only swizzle in this case, you can move the condition up and not
resolve the NSClassFromString or create an autorelease pool.

[jackhou1, 2015-03-05 04:28:08]

https://codereview.chromium.org/915313002/diff/60001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/custom_frame_view.mm (right):

https://codereview.chromium.org/915313002/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/custom_frame_view.mm:56: if
(base::mac::IsOSMavericksOrEarlier()) {
On 2015/03/04 19:16:26, Robert Sesek wrote:
> Since we only swizzle in this case, you can move the condition up and not
> resolve the NSClassFromString or create an autorelease pool.

Done.

[Robert Sesek, 2015-03-05 18:33:26]

LGTM

https://codereview.chromium.org/915313002/diff/100001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/custom_frame_view.mm (right):

https://codereview.chromium.org/915313002/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/custom_frame_view.mm:31: // In Yosemite, the fullscreen
button replaces the zoom button. We no longer
I think this is OK, but for extra safety I'd do this after the process --type
check.

[jackhou1, 2015-03-06 01:49:38]

https://codereview.chromium.org/915313002/diff/100001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/custom_frame_view.mm (right):

https://codereview.chromium.org/915313002/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/custom_frame_view.mm:31: // In Yosemite, the fullscreen
button replaces the zoom button. We no longer
On 2015/03/05 18:33:26, Robert Sesek wrote:
> I think this is OK, but for extra safety I'd do this after the process --type
> check.

Done.

[jackhou1, 2015-03-06 01:49:43]

The CQ bit was checked by jackhou@chromium.org

[jackhou1, 2015-03-06 01:49:43]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/915313002/#ps120001
(title: "Address comments")

[commit-bot: I haz the power, 2015-03-06 01:50:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/915313002/120001

[commit-bot: I haz the power, 2015-03-06 02:40:33]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-03-06 02:41:07]

Patchset 7 (id:??) landed as
https://crrev.com/dbf8bfd7fa34d69e880f0b8073a0441f439bf08a
Cr-Commit-Position: refs/heads/master@{#319395}