frog/member.dart - Issue 9153009: Minor code review change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/member.dart

Issue 9153009: Minor code review change. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: frog/member.dart

diff --git a/frog/member.dart b/frog/member.dart

index 2ebba2aa95ab2606368ee80e0a6f55c02da6b16a..9c0a0e966bcddc9c596913e5706d51100dc705f4 100644

--- a/frog/member.dart

+++ b/frog/member.dart

@@ -28,9 +28,7 @@ class Parameter {

// To match VM, detect cases where value was not actually specified in

// code and don't signal errors.

// TODO(jimhug): Clean up after issue #352 is resolved.

- if (definition.value.span.start == definition.span.start) {

- return;

- }

+ if (!hasDefaultValue) return;

if (method.name == ':call') {

// TODO(jimhug): Need simpler way to detect "true" function types vs.

« no previous file with comments | « no previous file | frog/minfrog » ('j') | no next file with comments »