Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 915243002: Add namespace sandbox status to LinuxSandbox::GetStatus. (Closed)

Created:
5 years, 10 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add namespace sandbox status to LinuxSandbox::GetStatus. Also add an extra check that the namespace sandbox is enabled in the zygote. BUG=312380 TBR=nasko@chromium.org Committed: https://crrev.com/c72852c0917f4b4c0b457c41897e79d8c99ab209 Cr-Commit-Position: refs/heads/master@{#315910}

Patch Set 1 #

Patch Set 2 : Add extra check that the namespace sandbox is enabled. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M content/common/sandbox_linux/sandbox_linux.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M content/public/common/sandbox_linux.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rickyz (no longer on Chrome)
Splitting this out of the sandbox about page change as you suggested.
5 years, 10 months ago (2015-02-12 01:04:41 UTC) #2
jln (very slow on Chromium)
lgtm Do you want to merge the CHECK that checks that GetStatus() is consistent with ...
5 years, 10 months ago (2015-02-12 01:17:57 UTC) #3
rickyz (no longer on Chrome)
On 2015/02/12 01:17:57, jln wrote: > lgtm > > Do you want to merge the ...
5 years, 10 months ago (2015-02-12 01:21:16 UTC) #5
jln (very slow on Chromium)
PS2 lgtm, but update the commit message.
5 years, 10 months ago (2015-02-12 01:21:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915243002/20001
5 years, 10 months ago (2015-02-12 01:24:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-12 02:13:44 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 02:14:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c72852c0917f4b4c0b457c41897e79d8c99ab209
Cr-Commit-Position: refs/heads/master@{#315910}

Powered by Google App Engine
This is Rietveld 408576698