chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc - Issue 915173011: Add store-locally checkbox to Android card unmasking prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc

Issue 915173011: Add store-locally checkbox to Android card unmasking prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: capitalization fail Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h ('k') | ui/android/java/strings/android_ui_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc

index d4437cba80ea3684990574c417105f9dcfbb1dc1..10be5c459748a089cce3b1927931a342c937e647 100644

--- a/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc

+++ b/chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc

@@ -47,6 +47,8 @@ void CardUnmaskPromptViewAndroid::Show() {

instructions.obj(),

ResourceMapper::MapFromChromiumId(controller_->GetCvcImageRid()),

controller_->ShouldRequestExpirationDate(),

+ // TODO(estade): controller_->GetStoreLocallyStartState(),

+ true,

view_android->GetWindowAndroid()->GetJavaObject().obj()));

Java_CardUnmaskBridge_show(env, java_object_.obj());

@@ -63,7 +65,9 @@ void CardUnmaskPromptViewAndroid::OnUserInput(JNIEnv* env,

jobject obj,

jstring cvc,

jstring month,

- jstring year) {

+ jstring year,

+ jboolean should_store_locally) {

+ // TODO(estade): pass should_store_locally.

controller_->OnUnmaskResponse(

base::android::ConvertJavaStringToUTF16(env, cvc),

base::android::ConvertJavaStringToUTF16(env, month),