Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 915173005: Revert of CPUProfiler: Push deopt reason further to ProfileNode. (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
Reviewers:
Jarin, Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of CPUProfiler: Push deopt reason further to ProfileNode. (patchset #1 id:1 of https://codereview.chromium.org/919953002/) Reason for revert: static initializers broke the build Original issue's description: > CPUProfiler: Push deopt reason further to ProfileNode. > > 1) create beefy RelocInfo table when cpu profiler is active, so if a function > was optimized when profiler was active RelocInfo would get separate DeoptInfo > for the each deopt case. > > 2) push DeoptInfo from CodeEntry to ProfileNode. > When deopt happens we put the info collected on #1 into CodeEntry and record stack sample. > On the sampling thread we grab the deopt data and append it to the corresponding ProfileNode deopts list. > > Sample profile dump. > [Top down]: > 0 (root) 0 #1 > 1 29 #2 > 5 test 29 #3 > 3 opt_function 29 #4 > deopted at 52 with reason 'not a heap number' > deopted at 71 with reason 'division by zero' > > BUG=452067 > LOG=n > > Committed: https://crrev.com/ce8701b247d3c6604f24f17a90c02d17b4417f54 > Cr-Commit-Position: refs/heads/master@{#26615} TBR=jarin@chromium.org,svenpanne@chromium.org,yurys@chromium.org,alph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452067 Committed: https://crrev.com/cb6ea146dc8813f7dc8fa7445d6d0f542509f317 Cr-Commit-Position: refs/heads/master@{#26616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -103 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/cpu-profiler-inl.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/deoptimizer.h View 2 chunks +10 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/profile-generator.h View 5 chunks +4 lines, -29 lines 0 comments Download
M src/profile-generator.cc View 5 chunks +9 lines, -29 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
loislo
Created Revert of CPUProfiler: Push deopt reason further to ProfileNode.
5 years, 10 months ago (2015-02-12 14:35:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/915173005/1
5 years, 10 months ago (2015-02-12 14:36:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 14:36:27 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 14:36:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb6ea146dc8813f7dc8fa7445d6d0f542509f317
Cr-Commit-Position: refs/heads/master@{#26616}

Powered by Google App Engine
This is Rietveld 408576698