Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: pkg/compiler/lib/src/js_emitter/model.dart

Issue 915043002: dart2js: Track holders better when they are deferred. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/model.dart
diff --git a/pkg/compiler/lib/src/js_emitter/model.dart b/pkg/compiler/lib/src/js_emitter/model.dart
index 2b7d351da325c30a2ff2e413313ada1e32a487d5..44314f52e8908e423e0087e27aa0ddd61161e969 100644
--- a/pkg/compiler/lib/src/js_emitter/model.dart
+++ b/pkg/compiler/lib/src/js_emitter/model.dart
@@ -15,6 +15,7 @@ import '../common.dart';
class Program {
final List<Fragment> fragments;
+ final List<Holder> holders;
final bool outputContainsConstantList;
final bool outputContainsNativeClasses;
final bool hasIsolateSupport;
@@ -30,6 +31,7 @@ class Program {
final MetadataCollector _metadataCollector;
Program(this.fragments,
+ this.holders,
this.loadMap,
this.typeToInterceptorMap,
this._metadataCollector,
@@ -95,8 +97,7 @@ abstract class Fragment {
this.staticLazilyInitializedFields,
this.constants);
- bool get isMainFragment => mainFragment == this;
- MainFragment get mainFragment;
+ bool get isMainFragment;
}
/**
@@ -107,7 +108,6 @@ abstract class Fragment {
*/
class MainFragment extends Fragment {
final js.Statement invokeMain;
- final List<Holder> holders;
MainFragment(OutputUnit outputUnit,
String outputFileName,
@@ -115,8 +115,7 @@ class MainFragment extends Fragment {
List<Library> libraries,
List<StaticField> staticNonFinalFields,
List<StaticField> staticLazilyInitializedFields,
- List<Constant> constants,
- this.holders)
+ List<Constant> constants)
: super(outputUnit,
outputFileName,
libraries,
@@ -124,22 +123,18 @@ class MainFragment extends Fragment {
staticLazilyInitializedFields,
constants);
- MainFragment get mainFragment => this;
+ bool get isMainFragment => true;
}
/**
* An output (file) for deferred code.
*/
class DeferredFragment extends Fragment {
- final MainFragment mainFragment;
final String name;
- List<Holder> get holders => mainFragment.holders;
-
DeferredFragment(OutputUnit outputUnit,
String outputFileName,
this.name,
- this.mainFragment,
List<Library> libraries,
List<StaticField> staticNonFinalFields,
List<StaticField> staticLazilyInitializedFields,
@@ -150,6 +145,8 @@ class DeferredFragment extends Fragment {
staticNonFinalFields,
staticLazilyInitializedFields,
constants);
+
+ bool get isMainFragment => false;
}
class Constant {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698