LayoutTests/battery-status/detached-no-crash.html - Issue 915033002: BatteryManager.getBattery(): gracefully bail on context-detached use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/battery-status/detached-no-crash.html

Issue 915033002: BatteryManager.getBattery(): gracefully bail on context-detached use. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tidying up test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/battery-status/detached-no-crash-expected.txt » ('j') | LayoutTests/http/tests/navigation/beacon-detached-no-crash.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/battery-status/detached-no-crash.html

diff --git a/LayoutTests/vibration/vibration-detached-no-crash.html b/LayoutTests/battery-status/detached-no-crash.html

similarity index 60%

copy from LayoutTests/vibration/vibration-detached-no-crash.html

copy to LayoutTests/battery-status/detached-no-crash.html

index 46b12de5a54a8e51b7acdd480115bf094bb626f8..3caf6e0543c46182c722c6e673fdf3b1c34aa7ae 100644

--- a/LayoutTests/vibration/vibration-detached-no-crash.html

+++ b/LayoutTests/battery-status/detached-no-crash.html

@@ -2,19 +2,23 @@

<body>

<head>

-<script src="vibration-utils.js"></script>

</head>

-description("Accessing navigator.vibrate on a closed window.");

+description("Accessing navigator.getBattery() on a closed window.");

window.jsTestIsAsync = true;

var w;

+var nav;

function processMessage(event) {

if (event.data == "opened") {

+ nav = w.navigator;

+ shouldBeTrue("typeof(nav.getBattery()) == 'object'");

w.close();

+ w = null;

} else if (event.data == "closed") {

- shouldBeFalse("w.navigator.vibrate([])");

+ shouldBeUndefined("nav.getBattery()");

finishJSTest();

}

@@ -23,7 +27,7 @@ if (window.testRunner) {

testRunner.dumpAsText();

testRunner.setCanOpenWindows();

}

-w = window.open('resources/vibration-detached-no-crash-new-window.html');

+w = window.open('../resources/window-postmessage-open-close.html');

window.addEventListener("message", processMessage, false);

</script>

</body>

« no previous file with comments | « no previous file | LayoutTests/battery-status/detached-no-crash-expected.txt » ('j') | LayoutTests/http/tests/navigation/beacon-detached-no-crash.html » ('J')