LayoutTests/http/tests/navigation/beacon-detached-no-crash.html - Issue 915033002: BatteryManager.getBattery(): gracefully bail on context-detached use.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/navigation/beacon-detached-no-crash.html

Issue 915033002: BatteryManager.getBattery(): gracefully bail on context-detached use. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tidying up test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/gamepad/resources/gamepad-detached-no-crash-new-window.html ('k') | LayoutTests/http/tests/navigation/resources/beacon-detached-no-crash-new-window.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="/js-test-resources/js-test.js"></script>	4 <script src="/js-test-resources/js-test.js"></script>

5 <script>	5 <script>

6 description("Accessing Navigator sendBeacon methods on a closed window.");	6 description("Accessing Navigator sendBeacon methods on a closed window.");

7	7

8 window.jsTestIsAsync = true;	8 window.jsTestIsAsync = true;

9	9

10 var w;	10 var w;

11 function processMessage(event) {	11 function processMessage(event) {

12 if (event.data == "opened") {	12 if (event.data == "opened") {

13 w.close();	13 w.close();

14 } else if (event.data == "closed") {	14 } else if (event.data == "closed") {

15 shouldThrow("w.navigator.sendBeacon()");	15 shouldThrow("w.navigator.sendBeacon()");

16 shouldBeFalse("w.navigator.sendBeacon('resources/blank.txt', 'detached-s hould-return false')");	16 shouldBeFalse("w.navigator.sendBeacon('resources/blank.txt', 'detached-s hould-return false')");

17 finishJSTest();	17 finishJSTest();

18 }	18 }

19 }	19 }

20	20

21 if (window.testRunner) {	21 if (window.testRunner) {

22 testRunner.dumpAsText();	22 testRunner.dumpAsText();

23 testRunner.setCanOpenWindows();	23 testRunner.setCanOpenWindows();

24 testRunner.waitUntilDone();	24 testRunner.waitUntilDone();

25 }	25 }

26 w = window.open('resources/beacon-detached-no-crash-new-window.html');	26 w = window.open('/js-test-resources/window-postmessage-open-close.html');
	Michael van Ouwerkerk 2015/02/12 14:31:32 Can we maybe use relative urls so that things also Can we maybe use relative urls so that things also work when running manually? sof 2015/02/12 15:51:15 That would be useful to also support for http/test Show quoted text On 2015/02/12 14:31:32, Michael van Ouwerkerk wrote: > Can we maybe use relative urls so that things also work when running manually? That would be useful to also support for http/tests/, but /js-test-resources/ is an alias (which is how js-test.js is slurped in atm for this test), so relativising this particular url wouldn't quite work, i think.
27 window.addEventListener("message", processMessage, false);	27 window.addEventListener("message", processMessage, false);

28 </script>	28 </script>

OLD	NEW