LayoutTests/gamepad/gamepad-detached-no-crash.html - Issue 915033002: BatteryManager.getBattery(): gracefully bail on context-detached use.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/gamepad/gamepad-detached-no-crash.html

Issue 915033002: BatteryManager.getBattery(): gracefully bail on context-detached use. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tidying up test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/files/resources/file-reader-detached-no-crash-new-window.html ('k') | LayoutTests/gamepad/resources/gamepad-detached-no-crash-new-window.html » ('j') | LayoutTests/http/tests/navigation/beacon-detached-no-crash.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="../resources/js-test.js"></script>	2 <script src="../resources/js-test.js"></script>

3 <script>	3 <script>

4 description("Accessing Navigator Gamepad methods on a closed window.");	4 description("Accessing Navigator Gamepad methods on a closed window.");

5	5

6 window.jsTestIsAsync = true;	6 window.jsTestIsAsync = true;

7	7

8 var expectedLength = 0;	8 var expectedLength = 0;

9 var w;	9 var w;

10 function processMessage(event) {	10 function processMessage(event) {

11 if (event.data == "opened") {	11 if (event.data == "opened") {

12 w.close();	12 w.close();

13 } else if (event.data == "closed") {	13 } else if (event.data == "closed") {

14 shouldBe("w.navigator.getGamepads().length", "expectedLength");	14 shouldBe("w.navigator.getGamepads().length", "expectedLength");

15 finishJSTest();	15 finishJSTest();

16 }	16 }

17 }	17 }

18	18

19 if (window.gamepadController) {	19 if (window.gamepadController) {

20 if (window.testRunner) {	20 if (window.testRunner) {

21 testRunner.dumpAsText();	21 testRunner.dumpAsText();

22 testRunner.setCanOpenWindows();	22 testRunner.setCanOpenWindows();

23 testRunner.waitUntilDone();	23 testRunner.waitUntilDone();

24 }	24 }

25 w = window.open('resources/gamepad-detached-no-crash-new-window.html');	25 w = window.open('../resources/window-postmessage-open-close.html');

26 expectedLength = w.navigator.getGamepads().length;	26 expectedLength = w.navigator.getGamepads().length;

27 window.addEventListener("message", processMessage, false);	27 window.addEventListener("message", processMessage, false);

28 } else {	28 } else {

29 console.log("FAIL: no gamepad controller available.")	29 console.log("FAIL: no gamepad controller available.")

30 }	30 }

31 </script>	31 </script>

OLD	NEW