Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Unified Diff: test/cctest/test-strings.cc

Issue 91503002: Mark deprecated APIs with relatively little use as deprecated (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-profile-generator.cc ('k') | test/cctest/test-weaktypedarrays.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-strings.cc
diff --git a/test/cctest/test-strings.cc b/test/cctest/test-strings.cc
index d0eabe30188729cdc574edd76c7a8212ec91c3d2..6f036338e880ac0125d5634ddc0e1fde9eacacb6 100644
--- a/test/cctest/test-strings.cc
+++ b/test/cctest/test-strings.cc
@@ -943,9 +943,9 @@ TEST(ExternalShortStringAdd) {
// Allocate two JavaScript arrays for holding short strings.
v8::Handle<v8::Array> ascii_external_strings =
- v8::Array::New(kMaxLength + 1);
+ v8::Array::New(CcTest::isolate(), kMaxLength + 1);
v8::Handle<v8::Array> non_ascii_external_strings =
- v8::Array::New(kMaxLength + 1);
+ v8::Array::New(CcTest::isolate(), kMaxLength + 1);
// Generate short ascii and non-ascii external strings.
for (int i = 0; i <= kMaxLength; i++) {
@@ -958,7 +958,7 @@ TEST(ExternalShortStringAdd) {
AsciiResource* ascii_resource =
new(&zone) AsciiResource(Vector<const char>(ascii, i));
v8::Local<v8::String> ascii_external_string =
- v8::String::NewExternal(ascii_resource);
+ v8::String::NewExternal(CcTest::isolate(), ascii_resource);
ascii_external_strings->Set(v8::Integer::New(i), ascii_external_string);
uc16* non_ascii = zone.NewArray<uc16>(i + 1);
@@ -969,7 +969,7 @@ TEST(ExternalShortStringAdd) {
// string data.
Resource* resource = new(&zone) Resource(Vector<const uc16>(non_ascii, i));
v8::Local<v8::String> non_ascii_external_string =
- v8::String::NewExternal(resource);
+ v8::String::NewExternal(CcTest::isolate(), resource);
non_ascii_external_strings->Set(v8::Integer::New(i),
non_ascii_external_string);
}
« no previous file with comments | « test/cctest/test-profile-generator.cc ('k') | test/cctest/test-weaktypedarrays.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698