Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: test/cctest/test-object-observe.cc

Issue 91503002: Mark deprecated APIs with relatively little use as deprecated (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-log-stack-tracer.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-object-observe.cc
diff --git a/test/cctest/test-object-observe.cc b/test/cctest/test-object-observe.cc
index ce5611183c71b463293d53eb634b418c6d036fc7..4c32d44dcb3fa5d4c624068327b593b76c840e77 100644
--- a/test/cctest/test-object-observe.cc
+++ b/test/cctest/test-object-observe.cc
@@ -526,7 +526,7 @@ static Handle<Object> CreateAccessCheckedObject(
Handle<Object> instance = tmpl->NewInstance();
Handle<Object> global = instance->CreationContext()->Global();
global->Set(String::NewFromUtf8(isolate, "obj"), instance);
- global->Set(kBlockedContextIndex, v8::True());
+ global->Set(kBlockedContextIndex, v8::True(isolate));
return instance;
}
@@ -761,8 +761,9 @@ TEST(HiddenPropertiesLeakage) {
"Object.observe(obj, observer);");
Handle<Value> obj =
context->Global()->Get(String::NewFromUtf8(isolate.GetIsolate(), "obj"));
- Handle<Object>::Cast(obj)->SetHiddenValue(
- String::NewFromUtf8(isolate.GetIsolate(), "foo"), Null());
+ Handle<Object>::Cast(obj)
+ ->SetHiddenValue(String::NewFromUtf8(isolate.GetIsolate(), "foo"),
+ Null(isolate.GetIsolate()));
CompileRun(""); // trigger delivery
CHECK(CompileRun("records")->IsNull());
}
« no previous file with comments | « test/cctest/test-log-stack-tracer.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698