Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: test/cctest/test-log.cc

Issue 91503002: Mark deprecated APIs with relatively little use as deprecated (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-log-stack-tracer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-log.cc
diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc
index b838fda5fedb97fbecc60bfdca2b7b2c09428e3c..6c91f72ec8ee70516e751ce5bd3bce96a7b8b256 100644
--- a/test/cctest/test-log.cc
+++ b/test/cctest/test-log.cc
@@ -305,7 +305,8 @@ TEST(Issue23768) {
env->Enter();
SimpleExternalString source_ext_str("(function ext() {})();");
- v8::Local<v8::String> source = v8::String::NewExternal(&source_ext_str);
+ v8::Local<v8::String> source =
+ v8::String::NewExternal(CcTest::isolate(), &source_ext_str);
// Script needs to have a name in order to trigger InitLineEnds execution.
v8::Handle<v8::String> origin =
v8::String::NewFromUtf8(CcTest::isolate(), "issue-23768-test");
@@ -336,7 +337,8 @@ TEST(LogCallbacks) {
v8::FunctionTemplate::New());
obj->SetClassName(v8_str("Obj"));
v8::Handle<v8::ObjectTemplate> proto = obj->PrototypeTemplate();
- v8::Local<v8::Signature> signature = v8::Signature::New(obj);
+ v8::Local<v8::Signature> signature =
+ v8::Signature::New(CcTest::isolate(), obj);
proto->Set(v8_str("method1"),
v8::FunctionTemplate::New(ObjMethod1,
v8::Handle<v8::Value>(),
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-log-stack-tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698