win: Fix InitializationStateDcheck in Release build

win: Fix InitializationStateDcheck in Release build

e:\b\build\slave\crashpad_win_rel\build\crashpad\util\misc\initialization_state_dcheck_test.cc(25) : error C2133: 'initialization_state_dcheck' : unknown size

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e774a63dbcd07c2ea021465df8241f66bee3a6f1

[Mark Mentovai, 2015-02-11 20:47:13]

https://codereview.chromium.org/915023003/diff/20001/util/misc/initialization...
File util/misc/initialization_state_dcheck.h (left):

https://codereview.chromium.org/915023003/diff/20001/util/misc/initialization...
util/misc/initialization_state_dcheck.h:159: // would still have a nonzero size
(rationale:
This comment explains why this wasn’t done before.

Since MSVC doesn’t accept the zero-length, can we at least make this conditional
on COMPILER_MSVC, to avoid wasting these bytes where it’s not necessary?

[scottmg, 2015-02-11 20:58:41]

Patchset #3 (id:40001) has been deleted

[scottmg, 2015-02-11 20:59:46]

Patchset #3 (id:10002) has been deleted

[scottmg, 2015-02-11 21:03:00]

Patchset #3 (id:70001) has been deleted

[scottmg, 2015-02-11 21:03:32]

https://codereview.chromium.org/915023003/diff/20001/util/misc/initialization...
File util/misc/initialization_state_dcheck.h (left):

https://codereview.chromium.org/915023003/diff/20001/util/misc/initialization...
util/misc/initialization_state_dcheck.h:159: // would still have a nonzero size
(rationale:
On 2015/02/11 20:47:12, Mark Mentovai wrote:
> This comment explains why this wasn’t done before.
> 
> Since MSVC doesn’t accept the zero-length, can we at least make this
conditional
> on COMPILER_MSVC, to avoid wasting these bytes where it’s not necessary?

Done.

It seemed unnecessarily tricky to me given the size and number of objects in
which it was used.

[Mark Mentovai, 2015-02-11 21:37:54]

LGTM

https://codereview.chromium.org/915023003/diff/90001/util/misc/initialization...
File util/misc/initialization_state_dcheck.h (right):

https://codereview.chromium.org/915023003/diff/90001/util/misc/initialization...
util/misc/initialization_state_dcheck.h:175: namespace internal {
Delete this whole thing now too, it’s unused.

[scottmg, 2015-02-11 21:38:56]

https://codereview.chromium.org/915023003/diff/90001/util/misc/initialization...
File util/misc/initialization_state_dcheck.h (right):

https://codereview.chromium.org/915023003/diff/90001/util/misc/initialization...
util/misc/initialization_state_dcheck.h:175: namespace internal {
On 2015/02/11 21:37:54, Mark Mentovai wrote:
> Delete this whole thing now too, it’s unused.

Done.

[scottmg, 2015-02-11 21:39:07]

New patchsets have been uploaded after l-g-t-m from mark@chromium.org

[scottmg, 2015-02-11 21:39:44]

Committed patchset #4 (id:110001) manually as
e774a63dbcd07c2ea021465df8241f66bee3a6f1 (presubmit successful).