Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: content/browser/download/download_manager_impl.cc

Issue 9150028: Cleanup: ResourceDispatcherHost::BeginDownload takes a scoped_ptr<URLRequest> argument. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/process_unique_id/child_id/ Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/download/download_manager_impl.h" 5 #include "content/browser/download/download_manager_impl.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 : render_process_id_(rpi), render_view_id_(rvi) {} 66 : render_process_id_(rpi), render_view_id_(rvi) {}
67 int render_process_id_; 67 int render_process_id_;
68 int render_view_id_; 68 int render_view_id_;
69 }; 69 };
70 70
71 void BeginDownload(const URLParams& url_params, 71 void BeginDownload(const URLParams& url_params,
72 const DownloadSaveInfo& save_info, 72 const DownloadSaveInfo& save_info,
73 ResourceDispatcherHost* resource_dispatcher_host, 73 ResourceDispatcherHost* resource_dispatcher_host,
74 const RenderParams& render_params, 74 const RenderParams& render_params,
75 const content::ResourceContext* context) { 75 const content::ResourceContext* context) {
76 net::URLRequest* request = new net::URLRequest(url_params.url_, 76 scoped_ptr<net::URLRequest> request(
77 resource_dispatcher_host); 77 new net::URLRequest(url_params.url_, resource_dispatcher_host));
78 request->set_referrer(url_params.referrer_.spec()); 78 request->set_referrer(url_params.referrer_.spec());
79 resource_dispatcher_host->BeginDownload( 79 resource_dispatcher_host->BeginDownload(
80 request, save_info, true, 80 request.Pass(), save_info, true,
81 DownloadResourceHandler::OnStartedCallback(), 81 DownloadResourceHandler::OnStartedCallback(),
82 render_params.render_process_id_, 82 render_params.render_process_id_,
83 render_params.render_view_id_, 83 render_params.render_view_id_,
84 *context); 84 *context);
85 } 85 }
86 86
87 } // namespace 87 } // namespace
88 88
89 namespace content { 89 namespace content {
90 90
(...skipping 1066 matching lines...) Expand 10 before | Expand all | Expand 10 after
1157 it != history_downloads_.end(); ++it) { 1157 it != history_downloads_.end(); ++it) {
1158 if (it->second->IsComplete() && !it->second->GetOpened()) 1158 if (it->second->IsComplete() && !it->second->GetOpened())
1159 ++num_unopened; 1159 ++num_unopened;
1160 } 1160 }
1161 download_stats::RecordOpensOutstanding(num_unopened); 1161 download_stats::RecordOpensOutstanding(num_unopened);
1162 } 1162 }
1163 1163
1164 void DownloadManagerImpl::SetFileManager(DownloadFileManager* file_manager) { 1164 void DownloadManagerImpl::SetFileManager(DownloadFileManager* file_manager) {
1165 file_manager_ = file_manager; 1165 file_manager_ = file_manager;
1166 } 1166 }
OLDNEW
« no previous file with comments | « chrome/browser/download/download_extension_api.cc ('k') | content/browser/renderer_host/render_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698