Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
9150023:
Add a cros autotest runner for omx_video_decode_accelerator_unittest (on ARM). (Closed)
|
Created:
8 years, 11 months ago by Ami GONE FROM CHROMIUM Modified:
8 years, 11 months ago CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd a cros autotest runner for omx_video_decode_accelerator_unittest (on ARM).
Also fixed a bug in v_d_a_unittest.cc where specifying the known switch would fall-through to the FATAL for unknown switches.
BUG=109828
TEST=Manual run passed: emerge-tegra2_kaen chromeos-chrome && run_remote_tests.sh --remote=<tegra2IP> --use_emerged OMXTest
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118849
Patch Set 1 #
Total comments: 4
Patch Set 2 : . #
Messages
Total messages: 12 (0 generated)
Dale: please review. This requires a cros ebuild CL, too, to work correctly, but I think they can land independently.
On 2012/01/19 09:34:19, Ami Fischman wrote: > Dale: please review. > This requires a cros ebuild CL, too, to work correctly, but I think they can > land independently. CrOS-side CL: https://gerrit.chromium.org/gerrit/14469
+cmasone for control file specifics. https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/au... File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control (right): https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/au... chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control:5: AUTHOR = "Chrome OS Team" We used to use a test list to decide which tests to run, but nowadays it's generated on the fly from these control files. I've added cmasone to review who designed this new system. Chris, we need to add this test to the ARM Tegra2 machines. What settings should Ami use here? Since this is a gtest executable there may also be some additional settings to get the results of each subtest parsed onto the dashboard. https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/au... chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control:9: This test will fail if any of the tests in omx_video_decode_accelerator_unittest fails. 80 chars.
https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/au... File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control (right): https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/au... chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control:9: This test will fail if any of the tests in omx_video_decode_accelerator_unittest fails. On 2012/01/19 18:22:45, DaleCurtis wrote: > 80 chars. Done.
Chris: ping? (see Dale's q to you below) Cheers, -a On Thu, Jan 19, 2012 at 10:22 AM, <dalecurtis@chromium.org> wrote: > +cmasone for control file specifics. > > > https://chromiumcodereview.**appspot.com/9150023/diff/1/** > chrome/test/chromeos/autotest/**files/client/site_tests/** > desktopui_OMXTest/control<https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control> > File > chrome/test/chromeos/autotest/**files/client/site_tests/** > desktopui_OMXTest/control > (right): > > https://chromiumcodereview.**appspot.com/9150023/diff/1/** > chrome/test/chromeos/autotest/**files/client/site_tests/** > desktopui_OMXTest/control#**newcode5<https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control#newcode5> > chrome/test/chromeos/autotest/**files/client/site_tests/** > desktopui_OMXTest/control:5: > AUTHOR = "Chrome OS Team" > We used to use a test list to decide which tests to run, but nowadays > it's generated on the fly from these control files. I've added cmasone > to review who designed this new system. > > Chris, we need to add this test to the ARM Tegra2 machines. What > settings should Ami use here? > > Since this is a gtest executable there may also be some additional > settings to get the results of each subtest parsed onto the dashboard. > > https://chromiumcodereview.**appspot.com/9150023/diff/1/** > chrome/test/chromeos/autotest/**files/client/site_tests/** > desktopui_OMXTest/control#**newcode9<https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control#newcode9> > chrome/test/chromeos/autotest/**files/client/site_tests/** > desktopui_OMXTest/control:9: > > This test will fail if any of the tests in > omx_video_decode_accelerator_**unittest fails. > 80 chars. > > https://chromiumcodereview.**appspot.com/9150023/<https://chromiumcodereview.... >
Please talk to scottz about this, as I'm working on some other P0 items. On Fri, Jan 20, 2012 at 9:31 AM, Ami Fischman <fischman@chromium.org> wrote: > Chris: ping? (see Dale's q to you below) > > Cheers, > -a > > On Thu, Jan 19, 2012 at 10:22 AM, <dalecurtis@chromium.org> wrote: > >> +cmasone for control file specifics. >> >> >> https://chromiumcodereview.**appspot.com/9150023/diff/1/** >> chrome/test/chromeos/autotest/**files/client/site_tests/** >> desktopui_OMXTest/control<https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control> >> File >> chrome/test/chromeos/autotest/**files/client/site_tests/** >> desktopui_OMXTest/control >> (right): >> >> https://chromiumcodereview.**appspot.com/9150023/diff/1/** >> chrome/test/chromeos/autotest/**files/client/site_tests/** >> desktopui_OMXTest/control#**newcode5<https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control#newcode5> >> chrome/test/chromeos/autotest/**files/client/site_tests/** >> desktopui_OMXTest/control:5: >> AUTHOR = "Chrome OS Team" >> We used to use a test list to decide which tests to run, but nowadays >> it's generated on the fly from these control files. I've added cmasone >> to review who designed this new system. >> >> Chris, we need to add this test to the ARM Tegra2 machines. What >> settings should Ami use here? >> >> Since this is a gtest executable there may also be some additional >> settings to get the results of each subtest parsed onto the dashboard. >> >> https://chromiumcodereview.**appspot.com/9150023/diff/1/** >> chrome/test/chromeos/autotest/**files/client/site_tests/** >> desktopui_OMXTest/control#**newcode9<https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control#newcode9> >> chrome/test/chromeos/autotest/**files/client/site_tests/** >> desktopui_OMXTest/control:9: >> >> This test will fail if any of the tests in >> omx_video_decode_accelerator_**unittest fails. >> 80 chars. >> >> https://chromiumcodereview.**appspot.com/9150023/<https://chromiumcodereview.... >> > >
Scott: can you please review & answer Dale's q to Chris (which he redir'd to you): https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/au... Thanks!
The code looks good, just need to understand when/where you want this to run. On 2012/01/20 19:20:35, Ami Fischman wrote: > Scott: can you please review & answer Dale's q to Chris (which he redir'd to > you): > https://chromiumcodereview.appspot.com/9150023/diff/1/chrome/test/chromeos/au... > > Thanks!
http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control (right): http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control:1: # Copyright (c) 2012 The Chromium Authors. All rights reserved. What suite should this be running in?
On Jan 24, 2012 7:46 AM, <scottz@chromium.org> wrote: > > > http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... > File > chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control > (right): > > http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... > chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control:1: > > # Copyright (c) 2012 The Chromium Authors. All rights reserved. > What suite should this be running in? I want this to run on a tegra2 bot, regularly. IIUC that means the cros autotest farm. I don't care what suite it runs in but it should only try to run on tegra2 - it'll fail elsewhere.
For the time being you are going to need to edit the chromeos_test_config.json file in the chromium os autotest check out under files/site_utils/chromeos_test_config.json, add a new desktopui_tegra2 category under groups and then add that to each target that should be testing this. I suspect it is tegra2-kaen-r18 only right now since that is top of tree. You can go ahead and commit this change as the next change that needs to be done is in a different the autotest chromium os repo. Feel free to ping me on chat if you have any questions. On 2012/01/24 15:49:51, Ami Fischman wrote: > On Jan 24, 2012 7:46 AM, <mailto:scottz@chromium.org> wrote: > > > > > > > http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... > > File > > > chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control > > (right): > > > > > http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... > > > chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control:1: > > > > # Copyright (c) 2012 The Chromium Authors. All rights reserved. > > What suite should this be running in? > > I want this to run on a tegra2 bot, regularly. IIUC that means the cros > autotest farm. I don't care what suite it runs in but it should only try > to run on tegra2 - it'll fail elsewhere.
On 2012/01/24 16:46:12, scottz wrote: > For the time being you are going to need to edit the chromeos_test_config.json > file in the chromium os autotest check out under > files/site_utils/chromeos_test_config.json, add a new desktopui_tegra2 category > under groups and then add that to each target that should be testing this. I > suspect it is tegra2-kaen-r18 only right now since that is top of tree. > > You can go ahead and commit this change as the next change that needs to be done > is in a different the autotest chromium os repo. Feel free to ping me on chat if > you have any questions. > > > > On 2012/01/24 15:49:51, Ami Fischman wrote: > > On Jan 24, 2012 7:46 AM, <mailto:scottz@chromium.org> wrote: > > > > > > > > > > > > http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... > > > File > > > > > > chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control > > > (right): > > > > > > > > > http://codereview.chromium.org/9150023/diff/1/chrome/test/chromeos/autotest/f... > > > > > > chrome/test/chromeos/autotest/files/client/site_tests/desktopui_OMXTest/control:1: > > > > > > # Copyright (c) 2012 The Chromium Authors. All rights reserved. > > > What suite should this be running in? > > > > I want this to run on a tegra2 bot, regularly. IIUC that means the cros > > autotest farm. I don't care what suite it runs in but it should only try > > to run on tegra2 - it'll fail elsewhere. LGTM |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
