Source/core/layout/LayoutBox.h - Issue 914993003: [CSS Grid Layout] Determine definite/indefinite size properly in nested grids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.h

Issue 914993003: [CSS Grid Layout] Determine definite/indefinite size properly in nested grids (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New version Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/percent-intrinsic-track-breadth-expected.txt ('k') | Source/core/layout/LayoutBox.cpp » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutBox.h

diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h

index 6818c2b22b5f32258d5e53be8ec811a9b7e7925b..4d88639aa09dd728cbe54de999a726b32736bde2 100644

--- a/Source/core/layout/LayoutBox.h

+++ b/Source/core/layout/LayoutBox.h

@@ -455,7 +455,7 @@ public:

virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = ComputeActual) const;

virtual LayoutUnit computeReplacedLogicalHeight() const;

- static bool logicalWidthIsResolvableFromBlock(const RenderBlock* containingBlock);

+ static bool logicalWidthIsResolvableFromBlock(const LayoutBox* containingBlock);

Julien - ping for review 2015/02/27 02:07:03 Let's make this a reference if we're touching the

Manuel Rego 2015/02/27 08:48:50 Done.

bool hasDefiniteLogicalWidth() const;

static bool percentageLogicalHeightIsResolvableFromBlock(const RenderBlock* containingBlock, bool outOfFlowPositioned);

bool hasDefiniteLogicalHeight() const;