LayoutTests/fast/css-grid-layout/percent-intrinsic-track-breadth-crash.html - Issue 914993003: [CSS Grid Layout] Determine definite/indefinite size properly in nested grids

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/percent-intrinsic-track-breadth-crash.html

Issue 914993003: [CSS Grid Layout] Determine definite/indefinite size properly in nested grids (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link href="resources/grid.css" rel="stylesheet">

	5 <style>

	6 .intrinsic {

	7 grid-template-rows: max-content;

	8 grid-template-columns: max-content;

	9 height: 500px;

	10 width: 500px;

	11 }

	12

	13 .percentage {

	14 grid-template-rows: 100%;

	15 grid-template-columns: 100%;

	16 height: 100%;

	17 width: 100%;

	18 }

	19 </style>

	20 <script type="text/javascript">

	21 if (window.testRunner)

	22 testRunner.dumpAsText();

	23 </script>

	24 </head>

	25 <body>

	26 <p>This test checks that percentage track breadths of intrinsic size do not crash on debug.</p>

	27 <div class="grid intrinsic">

	28 <div class="grid percentage">
	Julien - ping for review 2015/02/18 22:13:16 I assume we were also not resolving this correctly I assume we were also not resolving this correctly so how about a check-layout.js test. Manuel Rego 2015/02/25 16:57:59 Yeah, I've changed to a check-layout test and real Show quoted text On 2015/02/18 22:13:16, Julien Chaffraix - PST wrote: > I assume we were also not resolving this correctly so how about a > check-layout.js test. Yeah, I've changed to a check-layout test and realized that width was not working as expected yet.
	29 </div>

	30 </div>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/percent-intrinsic-track-breadth-crash-expected.txt » ('j') | Source/core/rendering/RenderBox.cpp » ('J')