native_client_sdk/src/libraries/ppapi_simple/ppapi_simple_c.a.linkerscript - Issue 914983003: [NaCl SDK] Switch ppapi_simple to C library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/libraries/ppapi_simple/ppapi_simple_c.a.linkerscript

Issue 914983003: [NaCl SDK] Switch ppapi_simple to C library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update sdk_files.list Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 INPUT(libppapi_simple_c_entry.a libppapi_simple_real.a)
	Sam Clegg 2015/02/19 21:24:20 Can these just be one library? Can these just be one library? binji 2015/02/20 17:33:47 I don't think so. The entrypoint needs to be stati Show quoted text On 2015/02/19 21:24:20, Sam Clegg wrote: > Can these just be one library? I don't think so. The entrypoint needs to be static, AFAICT, otherwise using EXTERN in the linkerscript seems to have no effect. I suppose we could make the "real" library static too... OK, just tried this but pnacl-ld barfs when using -l, so I should probably only add it where it is needed.
	2 EXTERN(PPP_InitializeModule PPP_ShutdownModule PPP_GetInterface)

OLD	NEW