Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 914973002: Create v8 roll branches in refs/heads. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev, Jakob Kummerow, hinoka, iannucci
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Create v8 roll branches in refs/heads. This is needed as normal chromium checkouts don't fetch branch-heads. These branches will also be replicated by GitHub and are fetched when cloning from the repository. The expected object size will be the same or smaller than before as we currently push the same information onto the candidates branch (which already is in refs/heads). The only difference is the increasing number of refs in refs/heads. BUG=chromium:451975 TBR=tandrii@chromium.org NOTRY=true LOG=n TEST=./script_test.py TEST=tools/release/create_release.py -r machenbach@chromium.org -a machenbach@chromium.org --dry-run Committed: https://crrev.com/44bc8646c3316ef75f00be9c404eccf6ca586505 Cr-Commit-Position: refs/heads/master@{#26629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M tools/release/create_release.py View 3 chunks +10 lines, -8 lines 0 comments Download
M tools/release/test_scripts.py View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-11 11:24:04 UTC) #2
tandrii(chromium)
LGTM I agree with reasoning. Let's go ahead with this one.
5 years, 10 months ago (2015-02-12 17:13:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914973002/1
5 years, 10 months ago (2015-02-12 18:34:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 18:34:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44bc8646c3316ef75f00be9c404eccf6ca586505 Cr-Commit-Position: refs/heads/master@{#26629}
5 years, 10 months ago (2015-02-12 18:34:43 UTC) #7
agable
I'm not particularly opposed to this -- obviously if you want to have a bunch ...
5 years, 10 months ago (2015-02-26 22:01:45 UTC) #8
Michael Achenbach
5 years, 9 months ago (2015-02-28 14:33:15 UTC) #9
Message was sent while issue was closed.
> A chromium checkout that is pulling v8 via DEPS will fetch whatever hash or
ref
> is specified in the DEPS file. It shouldn't matter if it's in refs/heads or
> elsewhere.

This simply doesn't work. I have no idea why. I explained a few cases in a
recent email thread that included you with the title "Fetching a DEPS revision
that's in branch-heads"

Here was a trial CL - by now the logs are gone, but I can submit a new one.
https://codereview.chromium.org/893633002/

This didn't even work in a local checkout of chromium, changing the DEPS and
then calling gclient sync.

Powered by Google App Engine
This is Rietveld 408576698