Listen for keyed service shutdown notifications in PrerenderMessageFilter.

Listen for keyed service shutdown notifications in PrerenderMessageFilter.

BUG=457590
Committed: https://crrev.com/a26edbf7fdee231812c9241a3607d72059335c6a
Cr-Commit-Position: refs/heads/master@{#317433}

[Bernhard Bauer, 2015-02-11 20:48:16]

bauerb@chromium.org changed reviewers:
+ gavinp@chromium.org

[Bernhard Bauer, 2015-02-11 20:48:16]

Please review.

[Bernhard Bauer, 2015-02-17 10:42:38]

Friendly ping now you're back :)

[Bernhard Bauer, 2015-02-20 16:16:41]

On 2015/02/17 10:42:38, Bernhard Bauer wrote:
> Friendly ping now you're back :)

Ping?

[davidben, 2015-02-20 20:00:45]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2015-02-20 20:00:46]

I think Gavin is still away. I'll go review this since I'm the last person to
have done much with prerender.

lgtm with comment.

https://codereview.chromium.org/914963002/diff/1/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_message_filter.cc (right):

https://codereview.chromium.org/914963002/diff/1/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_message_filter.cc:60: }
It doesn't look like this is ever called (and the constructor already ensures
it's built).

[Bernhard Bauer, 2015-02-20 20:07:01]

New patchsets have been uploaded after l-g-t-m from davidben@chromium.org

[Bernhard Bauer, 2015-02-20 20:11:19]

bauerb@chromium.org changed reviewers:
+ erg@chromium.org

[Bernhard Bauer, 2015-02-20 20:11:19]

Elliot, can I get an OWNERS review for c/b/profiles/ please?

https://codereview.chromium.org/914963002/diff/1/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_message_filter.cc (right):

https://codereview.chromium.org/914963002/diff/1/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_message_filter.cc:60: }
On 2015/02/20 20:00:45, David Benjamin wrote:
> It doesn't look like this is ever called (and the constructor already ensures
> it's built).

Oh, duh. The reason why this is necessary is because it's a static method that
gets called during browser startup to initialize the dependency graph.

I added the method call; good catch!

[davidben, 2015-02-20 20:13:16]

https://codereview.chromium.org/914963002/diff/20001/chrome/browser/prerender...
File chrome/browser/prerender/prerender_message_filter.cc (right):

https://codereview.chromium.org/914963002/diff/20001/chrome/browser/prerender...
chrome/browser/prerender/prerender_message_filter.cc:25: return
Singleton<ShutdownNotifierFactory>::get();
Oh, I missed this on the first pass, sorry.

Nit: include base/memory/singleton.h

[Elliot Glaysher, 2015-02-20 21:49:26]

lgtm

[Bernhard Bauer, 2015-02-20 22:19:33]

New patchsets have been uploaded after l-g-t-m from erg@chromium.org

[Bernhard Bauer, 2015-02-20 22:20:09]

https://codereview.chromium.org/914963002/diff/20001/chrome/browser/prerender...
File chrome/browser/prerender/prerender_message_filter.cc (right):

https://codereview.chromium.org/914963002/diff/20001/chrome/browser/prerender...
chrome/browser/prerender/prerender_message_filter.cc:25: return
Singleton<ShutdownNotifierFactory>::get();
On 2015/02/20 20:13:15, David Benjamin wrote:
> Oh, I missed this on the first pass, sorry.
> 
> Nit: include base/memory/singleton.h

Done.

[Bernhard Bauer, 2015-02-20 22:20:13]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2015-02-20 22:21:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/914963002/40001

[commit-bot: I haz the power, 2015-02-20 23:05:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-20 23:06:11]

Patchset 3 (id:??) landed as
https://crrev.com/a26edbf7fdee231812c9241a3607d72059335c6a
Cr-Commit-Position: refs/heads/master@{#317433}