Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: tools/gn/example/build/BUILD.gn

Issue 914873002: Rework handling of os and cpu_arch in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update w/ review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_args.cc ('k') | tools/gn/format_test_data/032.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/example/build/BUILD.gn
diff --git a/tools/gn/example/build/BUILD.gn b/tools/gn/example/build/BUILD.gn
index 62243725a569f287d94ba65fffc1b5403d456fe3..8eae46a1aad929682f1d8b0468aa33cfac4fb028 100644
--- a/tools/gn/example/build/BUILD.gn
+++ b/tools/gn/example/build/BUILD.gn
@@ -3,7 +3,7 @@
# found in the LICENSE file.
config("compiler_defaults") {
- if (os == "linux") {
+ if (current_os == "linux") {
cflags = [
"-fPIC",
"-pthread",
« no previous file with comments | « tools/gn/command_args.cc ('k') | tools/gn/format_test_data/032.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698