Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2386)

Unified Diff: remoting/protocol/chromium_socket_factory.cc

Issue 914853002: Add CHECK() in UdpSocketLibevent to debug crbug.com/452121 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/udp/udp_socket_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/chromium_socket_factory.cc
diff --git a/remoting/protocol/chromium_socket_factory.cc b/remoting/protocol/chromium_socket_factory.cc
index 6b2c4fc69d8038b89f975251c5ab2d84ffe7f24a..0b6504520116420a500d7f150045b3b57811770f 100644
--- a/remoting/protocol/chromium_socket_factory.cc
+++ b/remoting/protocol/chromium_socket_factory.cc
@@ -198,6 +198,12 @@ int UdpPacketSocket::SendTo(const void* data, size_t data_size,
int UdpPacketSocket::Close() {
state_ = STATE_CLOSED;
+
+ // This CHECK() was added to debug crbug.com/452121 .
+ //
+ // TODO(sergeyu): Remove once the bug is resolved.
+ CHECK_NE(socket_->Close(), net::ERR_INVALID_HANDLE);
+
socket_.reset();
return 0;
}
« no previous file with comments | « net/udp/udp_socket_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698