Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 91483002: Add gdb.printing import in gdb chrome python file for issue 226278 (gdb (Closed)

Created:
7 years ago by ziran.sun
Modified:
7 years ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add gdb.printing import in gdb chrome python file for issue 226278 (gdb module doesn't exit) BUG=226278 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239404

Patch Set 1 #

Patch Set 2 : add gdb.printing import #

Patch Set 3 : add gdb.printing import #

Total comments: 1

Patch Set 4 : add gdb.printing import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gdb/gdb_chrome.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jeffrey Yasskin
LGTM If you're not a committer, I'll have to click the commit box for you, ...
7 years ago (2013-11-27 18:45:16 UTC) #1
ziran.sun
On 2013/11/27 18:45:16, Jeffrey Yasskin wrote: > LGTM > > If you're not a committer, ...
7 years ago (2013-11-28 09:57:43 UTC) #2
lgombos
On 2013/11/28 09:57:43, ziran.sun wrote: > On 2013/11/27 18:45:16, Jeffrey Yasskin wrote: > I have ...
7 years ago (2013-12-03 01:08:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/91483002/60001
7 years ago (2013-12-07 21:30:59 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-08 22:13:45 UTC) #5
Message was sent while issue was closed.
Change committed as 239404

Powered by Google App Engine
This is Rietveld 408576698