[App banners] Start addressing race conditions

chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.banners;
 
 import android.text.TextUtils;
 
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.CalledByNative;
@@ skipping 128 matching lines @@
     static void setIsEnabledForTesting() {
         sIsEnabled = true;
     }
 
     /** Sets a constant (in days) that gets added to the time when the current time is requested. */
     @VisibleForTesting
     static void setTimeDeltaForTesting(int days) {
         nativeSetTimeDeltaForTesting(days);
     }
 
-    /** Records how many native BitmapFetchers are actively retrieving app icons. */
+    /** Returns whether a BitmapFetcher is actively retrieving an app icon. */
     @VisibleForTesting
-    public int getNumActiveFetchersForTesting() {
-        return nativeGetNumActiveFetchers(mNativePointer);
+    public boolean isFetcherActiveForTesting() {
+        return nativeIsFetcherActive(mNativePointer);
     }
 
     private static native boolean nativeIsEnabled();
     private native long nativeInit();
     private native void nativeDestroy(long nativeAppBannerManager);
     private native void nativeReplaceWebContents(long nativeAppBannerManager,
             WebContents webContents);
     private native boolean nativeOnAppDetailsRetrieved(long nativeAppBannerManager, AppData data,
             String title, String packageName, String imageUrl);
 
     // Testing methods.
     private static native void nativeSetTimeDeltaForTesting(int days);
-    private native int nativeGetNumActiveFetchers(long nativeAppBannerManager);
+    private native boolean nativeIsFetcherActive(long nativeAppBannerManager);
 
     // UMA tracking.
     private static native void nativeRecordDismissEvent(int metric);
     private static native void nativeRecordInstallEvent(int metric);
 }