Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(58)

Issue 9148006: [objects] seed NumberDictionary (only ia32 now)

Created:
7 years, 7 months ago by indutny
Modified:
7 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Base URL:
gh:v8/v8@master
Visibility:
Public.

Description

[objects] seed NumberDictionary (only ia32 now) BUG= TEST= R=erik.corry@gmail.com

Patch Set 1 #

Patch Set 2 : seed to everything! #

Patch Set 3 : fixed wrapping lines #

Patch Set 4 : fixed wrapping, again #

Patch Set 5 : fixed lint issues #

Total comments: 12

Patch Set 6 : [objects] remove nameless argument, use BaseShape #

Total comments: 5

Patch Set 7 : arch support, fixed issues #

Patch Set 8 : added test, decoupled code #

Total comments: 13

Patch Set 9 : rebased #

Patch Set 10 : fixed issues, fixed rebase #

Patch Set 11 : fixed linter issues, use pseudo-random function in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -126 lines) Patch
M src/arm/macro-assembler-arm.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 6 7 8 9 2 chunks +30 lines, -18 lines 0 comments Download
M src/debug.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -1 line 0 comments Download
M src/frames.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 6 7 8 9 2 chunks +44 lines, -24 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 6 7 8 9 2 chunks +39 lines, -27 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 9 chunks +49 lines, -8 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 9 2 chunks +17 lines, -4 lines 0 comments Download
M src/profile-generator.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +8 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +12 lines, -8 lines 0 comments Download
M src/utils.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 6 7 8 9 2 chunks +37 lines, -24 lines 0 comments Download
M test/cctest/test-hashing.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +88 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
indutny
7 years, 7 months ago (2012-01-09 13:54:35 UTC) #1
indutny
sorry, patch is incomplete/incorrect now, fixing it right now
7 years, 7 months ago (2012-01-09 13:54:54 UTC) #2
indutny
I think it works now, can you please review?
7 years, 7 months ago (2012-01-09 16:05:12 UTC) #3
indutny
I can add const bool variable UsesSeed to all shapes. And check it before calling ...
7 years, 7 months ago (2012-01-09 16:17:51 UTC) #4
Erik Corry
http://codereview.chromium.org/9148006/diff/1011/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9148006/diff/1011/src/ia32/macro-assembler-ia32.cc#newcode997 src/ia32/macro-assembler-ia32.cc:997: lea(r1, Operand(seed, RelocInfo::NONE)); No reason to use lea here ...
7 years, 7 months ago (2012-01-09 23:52:47 UTC) #5
indutny
updated commit request. Removed all useless arguments, added const bool variable and SeededHash method to ...
7 years, 7 months ago (2012-01-10 06:02:39 UTC) #6
Erik Corry
http://codereview.chromium.org/9148006/diff/8001/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/9148006/diff/8001/src/objects-inl.h#newcode2061 src/objects-inl.h:2061: HashTable<Shape, Key>::Hash(key), This all fits on one line. http://codereview.chromium.org/9148006/diff/8001/src/objects-inl.h#newcode4542 ...
7 years, 7 months ago (2012-01-10 07:29:28 UTC) #7
Erik Corry
http://codereview.chromium.org/9148006/diff/8001/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9148006/diff/8001/src/ia32/macro-assembler-ia32.cc#newcode987 src/ia32/macro-assembler-ia32.cc:987: // First of all lets assign to r1 value ...
7 years, 7 months ago (2012-01-10 10:13:51 UTC) #8
indutny
Should be fixed now. Tested in debug and release mode with snapshots and w/o.
7 years, 7 months ago (2012-01-10 10:17:26 UTC) #9
indutny
Added test, fixed code, decoupled things :)
7 years, 7 months ago (2012-01-10 11:34:55 UTC) #10
indutny
rebased
7 years, 7 months ago (2012-01-10 11:53:02 UTC) #11
Erik Corry
Thanks for doing the test. http://codereview.chromium.org/9148006/diff/9008/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/9148006/diff/9008/src/arm/macro-assembler-arm.cc#newcode1420 src/arm/macro-assembler-arm.cc:1420: mov(scratch, Operand(scratch, LSR, kSmiTagSize)); ...
7 years, 7 months ago (2012-01-10 11:53:16 UTC) #12
indutny
7 years, 7 months ago (2012-01-10 12:30:09 UTC) #13
Fixed issues, fixed rebase

Powered by Google App Engine
This is Rietveld 408576698