Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 914773002: Fix issue with super and computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1783 matching lines...) Expand 10 before | Expand all | Expand 10 after
1794 __ push(a0); 1794 __ push(a0);
1795 1795
1796 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) { 1796 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) {
1797 DCHECK(!property->is_computed_name()); 1797 DCHECK(!property->is_computed_name());
1798 VisitForStackValue(value); 1798 VisitForStackValue(value);
1799 DCHECK(property->emit_store()); 1799 DCHECK(property->emit_store());
1800 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1800 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1801 } else { 1801 } else {
1802 EmitPropertyKey(property, expr->GetIdForProperty(property_index)); 1802 EmitPropertyKey(property, expr->GetIdForProperty(property_index));
1803 VisitForStackValue(value); 1803 VisitForStackValue(value);
1804 EmitSetHomeObjectIfNeeded(value, 2);
1804 1805
1805 switch (property->kind()) { 1806 switch (property->kind()) {
1806 case ObjectLiteral::Property::CONSTANT: 1807 case ObjectLiteral::Property::CONSTANT:
1807 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1808 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1808 case ObjectLiteral::Property::COMPUTED: 1809 case ObjectLiteral::Property::COMPUTED:
1809 if (property->emit_store()) { 1810 if (property->emit_store()) {
1810 __ li(a0, Operand(Smi::FromInt(NONE))); 1811 __ li(a0, Operand(Smi::FromInt(NONE)));
1811 __ push(a0); 1812 __ push(a0);
1812 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4); 1813 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);
1813 } else { 1814 } else {
(...skipping 3550 matching lines...) Expand 10 before | Expand all | Expand 10 after
5364 Assembler::target_address_at(pc_immediate_load_address)) == 5365 Assembler::target_address_at(pc_immediate_load_address)) ==
5365 reinterpret_cast<uint32_t>( 5366 reinterpret_cast<uint32_t>(
5366 isolate->builtins()->OsrAfterStackCheck()->entry())); 5367 isolate->builtins()->OsrAfterStackCheck()->entry()));
5367 return OSR_AFTER_STACK_CHECK; 5368 return OSR_AFTER_STACK_CHECK;
5368 } 5369 }
5369 5370
5370 5371
5371 } } // namespace v8::internal 5372 } } // namespace v8::internal
5372 5373
5373 #endif // V8_TARGET_ARCH_MIPS 5374 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698