Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 914773002: Fix issue with super and computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1720 matching lines...) Expand 10 before | Expand all | Expand 10 after
1731 __ push(Operand(esp, 0)); // Duplicate receiver. 1731 __ push(Operand(esp, 0)); // Duplicate receiver.
1732 1732
1733 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) { 1733 if (property->kind() == ObjectLiteral::Property::PROTOTYPE) {
1734 DCHECK(!property->is_computed_name()); 1734 DCHECK(!property->is_computed_name());
1735 VisitForStackValue(value); 1735 VisitForStackValue(value);
1736 DCHECK(property->emit_store()); 1736 DCHECK(property->emit_store());
1737 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1737 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1738 } else { 1738 } else {
1739 EmitPropertyKey(property, expr->GetIdForProperty(property_index)); 1739 EmitPropertyKey(property, expr->GetIdForProperty(property_index));
1740 VisitForStackValue(value); 1740 VisitForStackValue(value);
1741 EmitSetHomeObjectIfNeeded(value, 2);
1741 1742
1742 switch (property->kind()) { 1743 switch (property->kind()) {
1743 case ObjectLiteral::Property::CONSTANT: 1744 case ObjectLiteral::Property::CONSTANT:
1744 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1745 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1745 case ObjectLiteral::Property::COMPUTED: 1746 case ObjectLiteral::Property::COMPUTED:
1746 if (property->emit_store()) { 1747 if (property->emit_store()) {
1747 __ push(Immediate(Smi::FromInt(NONE))); 1748 __ push(Immediate(Smi::FromInt(NONE)));
1748 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4); 1749 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked, 4);
1749 } else { 1750 } else {
1750 __ Drop(3); 1751 __ Drop(3);
(...skipping 3541 matching lines...) Expand 10 before | Expand all | Expand 10 after
5292 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5293 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5293 Assembler::target_address_at(call_target_address, 5294 Assembler::target_address_at(call_target_address,
5294 unoptimized_code)); 5295 unoptimized_code));
5295 return OSR_AFTER_STACK_CHECK; 5296 return OSR_AFTER_STACK_CHECK;
5296 } 5297 }
5297 5298
5298 5299
5299 } } // namespace v8::internal 5300 } } // namespace v8::internal
5300 5301
5301 #endif // V8_TARGET_ARCH_IA32 5302 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698