Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 914723002: Small change to use a GrGeometryProcessor for all BitmapText draw calls (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Small change to use a GrGeometryProcessor for all BitmapText draw calls BUG=skia: Committed: https://skia.googlesource.com/skia/+/02b05015b55d1900a9e34039942101da189053ce

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup #

Patch Set 4 : adding bench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -53 lines) Patch
M bench/TextBench.cpp View 1 2 3 6 chunks +35 lines, -3 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 chunk +13 lines, -27 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 3 chunks +8 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 2 5 chunks +56 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
joshualitt
5 years, 10 months ago (2015-02-10 21:20:58 UTC) #3
jvanverth1
It looks okay -- have you checked performance at all?
5 years, 10 months ago (2015-02-10 21:31:06 UTC) #4
joshualitt
On 2015/02/10 21:31:06, jvanverth1 wrote: > It looks okay -- have you checked performance at ...
5 years, 10 months ago (2015-02-10 22:12:39 UTC) #5
jvanverth1
lgtm
5 years, 10 months ago (2015-02-11 14:04:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914723002/60001
5 years, 10 months ago (2015-02-11 14:49:54 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 14:56:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/02b05015b55d1900a9e34039942101da189053ce

Powered by Google App Engine
This is Rietveld 408576698