Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 914713002: Remove Function.prototype.toMethod (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Function.prototype.toMethod Function.prototype.toMethod was removed from ES6. This removes the function and updates the tests to either use %ToMethod or a dedicated syntax (using concise method or a class). BUG=v8:3330 LOG=N R=dslomov@chromium.org, adamk Committed: https://crrev.com/68e489758607bb7373409b49a0a7883407a322b3 Cr-Commit-Position: refs/heads/master@{#26559}

Patch Set 1 #

Patch Set 2 : extracted js perf test to a different cl #

Total comments: 1

Patch Set 3 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -74 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -2 lines 0 comments Download
D src/harmony-classes.js View 1 chunk +0 lines, -35 lines 0 comments Download
M src/messages.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 5 chunks +15 lines, -11 lines 0 comments Download
M test/mjsunit/harmony/super.js View 3 chunks +13 lines, -6 lines 0 comments Download
M test/mjsunit/harmony/toMethod.js View 1 2 6 chunks +7 lines, -16 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
arv (Not doing code reviews)
extracted js perf test to a different cl
5 years, 10 months ago (2015-02-10 21:17:31 UTC) #1
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-10 21:18:47 UTC) #2
adamk
lgtm % nit https://codereview.chromium.org/914713002/diff/20001/test/mjsunit/harmony/toMethod.js File test/mjsunit/harmony/toMethod.js (right): https://codereview.chromium.org/914713002/diff/20001/test/mjsunit/harmony/toMethod.js#newcode8 test/mjsunit/harmony/toMethod.js:8: // Function.prototype.toMethod was removed from the ...
5 years, 10 months ago (2015-02-10 21:27:29 UTC) #3
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-10 21:45:00 UTC) #4
arv (Not doing code reviews)
Remove comment
5 years, 10 months ago (2015-02-10 21:49:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/914713002/40001
5 years, 10 months ago (2015-02-10 21:50:22 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-10 22:13:37 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 22:13:50 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68e489758607bb7373409b49a0a7883407a322b3
Cr-Commit-Position: refs/heads/master@{#26559}

Powered by Google App Engine
This is Rietveld 408576698