Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/services/gcm/fake_gcm_profile_service.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Now compiles and passes tests (and uses CHECK_EQ) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/fake_gcm_profile_service.cc
diff --git a/chrome/browser/services/gcm/fake_gcm_profile_service.cc b/chrome/browser/services/gcm/fake_gcm_profile_service.cc
index 3d2d2109cdfbe5eb0858b789bccd4fbc4c3e5837..702100e5f16568453455052cf6952592675af3d4 100644
--- a/chrome/browser/services/gcm/fake_gcm_profile_service.cc
+++ b/chrome/browser/services/gcm/fake_gcm_profile_service.cc
@@ -37,7 +37,8 @@ class CustomFakeGCMDriver : public FakeGCMDriver {
// FakeGCMDriver overrides:
void RegisterImpl(const std::string& app_id,
const std::vector<std::string>& sender_ids) override;
- void UnregisterImpl(const std::string& app_id) override;
+ void UnregisterImpl(const std::string& app_id,
+ const std::vector<std::string>& sender_ids) override;
void SendImpl(const std::string& app_id,
const std::string& receiver_id,
const GCMClient::OutgoingMessage& message) override;
@@ -66,7 +67,9 @@ void CustomFakeGCMDriver::RegisterImpl(
sender_ids));
}
-void CustomFakeGCMDriver::UnregisterImpl(const std::string& app_id) {
+void CustomFakeGCMDriver::UnregisterImpl(
+ const std::string& app_id,
+ const std::vector<std::string>& sender_ids) {
base::MessageLoop::current()->PostTask(
FROM_HERE, base::Bind(
&FakeGCMProfileService::UnregisterFinished,

Powered by Google App Engine
This is Rietveld 408576698