Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: content/browser/push_messaging/push_messaging_message_filter.h

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweak comment per jianli Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging/push_messaging_message_filter.h
diff --git a/content/browser/push_messaging/push_messaging_message_filter.h b/content/browser/push_messaging/push_messaging_message_filter.h
index 8de53e5311661cbd6746029d77398b0f1764adab..10778275d643b6fc5e48ee3f9475b196804876bc 100644
--- a/content/browser/push_messaging/push_messaging_message_filter.h
+++ b/content/browser/push_messaging/push_messaging_message_filter.h
@@ -96,11 +96,19 @@ class PushMessagingMessageFilter : public BrowserMessageFilter {
void OnUnregister(int request_id, int64 service_worker_registration_id);
- void DoUnregister(int request_id,
- int64 service_worker_registration_id,
- const GURL& requesting_origin,
- const std::string& push_registration_id,
- ServiceWorkerStatusCode service_worker_status);
+ void UnregisterHavingGottenPushRegistrationId(
+ int request_id,
+ int64 service_worker_registration_id,
+ const GURL& requesting_origin,
+ const std::string& push_registration_id,
+ ServiceWorkerStatusCode service_worker_status);
+
+ void UnregisterHavingGottenSenderId(
+ int request_id,
+ int64 service_worker_registration_id,
+ const GURL& requesting_origin,
+ const std::string& sender_id,
+ ServiceWorkerStatusCode service_worker_status);
// Called via PostTask from UI thread.
void ClearRegistrationData(int request_id,

Powered by Google App Engine
This is Rietveld 408576698