Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: components/gcm_driver/gcm_driver_android.cc

Issue 914693002: Push API: Fix unsubscribing from GCM on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed peter's nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_android.cc
diff --git a/components/gcm_driver/gcm_driver_android.cc b/components/gcm_driver/gcm_driver_android.cc
index 93b2f919ba32db7106a503b8fade0ae7c2cdcb6d..2f82fbec91c434a9fddaf104e4f460ae921a4c30 100644
--- a/components/gcm_driver/gcm_driver_android.cc
+++ b/components/gcm_driver/gcm_driver_android.cc
@@ -169,20 +169,26 @@ GCMClient::Result GCMDriverAndroid::EnsureStarted(
}
void GCMDriverAndroid::RegisterImpl(
- const std::string& app_id,
- const std::vector<std::string>& sender_ids) {
+ const std::string& app_id, const std::vector<std::string>& sender_ids) {
+ DCHECK_EQ(1u, sender_ids.size());
JNIEnv* env = AttachCurrentThread();
Java_GCMDriver_register(
env, java_ref_.obj(),
ConvertUTF8ToJavaString(env, app_id).Release(),
- ToJavaArrayOfStrings(env, sender_ids).obj());
+ ConvertUTF8ToJavaString(env, sender_ids[0]).Release());
}
void GCMDriverAndroid::UnregisterImpl(const std::string& app_id) {
+ NOTREACHED();
+}
+
+void GCMDriverAndroid::UnregisterWithSenderIdImpl(
+ const std::string& app_id, const std::string& sender_id) {
JNIEnv* env = AttachCurrentThread();
Java_GCMDriver_unregister(
env, java_ref_.obj(),
- ConvertUTF8ToJavaString(env, app_id).Release());
+ ConvertUTF8ToJavaString(env, app_id).Release(),
+ ConvertUTF8ToJavaString(env, sender_id).Release());
}
void GCMDriverAndroid::SendImpl(const std::string& app_id,

Powered by Google App Engine
This is Rietveld 408576698